1119831 - Typos in apps/communications/dialer/js/call_log_db.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Max Schaefer]

There are three instances (https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/call_log_db.js#L944, https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/call_log_db.js#L1077, https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/call_log_db.js#L1158) of this snippet of code:

    if (!callback || !callback instanceof Function) {

Note that "!" binds more tightly than "instanceof", so this will check whether a Boolean is instanceof Function, which always yields "false".

Comment 1

[Gabriele Svelto [:gsvelto] (PTO)]

Confirming, thanks for reporting this.

Comment 2

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: [PATCH] Fixed typos that prevented us from checking callback types correctly

Comment 3

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: [PULL REQUEST] Fixed typos that prevented us from checking callback types correctly

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

Green try run: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=b5a8fb1c79f3

Pushed to gaia/master 9db430f16a6517cc6d0235c04481d64c20c81bf5

https://github.com/mozilla-b2g/gaia/commit/9db430f16a6517cc6d0235c04481d64c20c81bf5