1119832 - Typo in apps/system/js/async_semaphore.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Max Schaefer]

Constructor AsyncSemaphore tries to guard against being called without 'new' by the following test (https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/async_semaphore.js#L8):

    if (!this instanceof AsyncSemaphore) {
      return new AsyncSemaphore();
    }

Note, however, that '!' binds more tightly than 'instanceof', so the 'if' condition will always evaluate to 'false', rendering the guard ineffective.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1119832_async_semaphore_typo to mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8553959 [details] [review]
[PullReq] KevinGrandon:bug_1119832_async_semaphore_typo to mozilla-b2g:master

Max - thank you for filing this bug.

Tzu-Lin - could you give this a quick review? Just fixing the syntax and adding a quick unit test.

Comment 3

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8553959 [details] [review]
[PullReq] KevinGrandon:bug_1119832_async_semaphore_typo to mozilla-b2g:master

Nice catch, thanks

Comment 4

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/0f662dffef27599443cfcd790c2b39190a2b35c8