Infinite scroll doesn't happen

RESOLVED FIXED

Status

Webtools
DXR
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: erik, Assigned: mkelly)

Tracking

Trunk
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: js)

(Reporter)

Description

4 years ago
This is on the "es" branch.

We've managed to break infinite scrolling on the ES branch somehow. I don't see anything obvious in the error console. It just does nothing. To repro:

1. Put 100 or so lines that match a search query into, say, test_basic/code/README.mkd. I like to use something like...

    1 bottle of frobscottle on the wall
    2 bottles of frobscottle on the wall
    3 bottles of frobscottle on the wall
    etc.

That way, they're nicely numbered so you can see if the search found them all.

2. Resize your browser window to be vertically small, so not all the results load initially.

3. Search for, say, "frobscottle". Hit Return, or don't; both fail.

4. Scroll to the bottom. No more results load.
(Reporter)

Updated

3 years ago
Blocks: 1127125
Ugh, how things change.... So, I honestly do not know when I will get to this so, I am opening the doors to anyone interested in picking this up. Sorry :erik :(
Assignee: schalk.neethling.bugs → nobody
(Reporter)

Comment 3

3 years ago
Failing all else, I'll take care of it. Best of luck in your new position!
(Assignee)

Comment 4

3 years ago
I VOLUNTEER AS TRIBUTE
Assignee: nobody → mkelly
(Reporter)

Comment 5

3 years ago
May the odds (and we have plenty of them) be ever in your favor.

Comment 6

3 years ago
Commit pushed to es at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/589decba227d97d15cf1bccdcbaf97d3d869c2e8
Fix bug 1119862: Fix infinite scrolling.

Fixes the infinite scroll to append lines to files that are already
shown on the page instead of creating a new file entry in the search
results.

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.