Closed Bug 1119933 Opened 6 years ago Closed 6 years ago

Filter out platform frames in the flamegraph for the new performance tool

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 38

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(1 file)

No description provided.
Blocks: perf-tool-v2
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attached patch v1Splinter Review
Attachment #8547672 - Flags: review?(jsantell)
Comment on attachment 8547672 [details] [diff] [review]
v1

Review of attachment 8547672 [details] [diff] [review]:
-----------------------------------------------------------------

Seems a bit strange to have a boolean indicate whether the predicate is used or not -- can we just make it use the predicate if provided?

let dataSrc = FlameGraphUtils.createFlameGraphDataFromSamples(samples, {
  flattenRecursion: Prefs.flattenTreeRecursion,
  contentPredicate: !Prefs.showPlatformData && FrameNode.isContent
});
Attachment #8547672 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/aeffa71cbbb0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.