1119933 - Filter out platform frames in the flamegraph for the new performance tool

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8547672 [details] [diff] [review]
v1

Review of attachment 8547672 [details] [diff] [review]:
-----------------------------------------------------------------

Seems a bit strange to have a boolean indicate whether the predicate is used or not -- can we just make it use the predicate if provided?

let dataSrc = FlameGraphUtils.createFlameGraphDataFromSamples(samples, {
  flattenRecursion: Prefs.flattenTreeRecursion,
  contentPredicate: !Prefs.showPlatformData && FrameNode.isContent
});

Comment 3

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/aeffa71cbbb0

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/aeffa71cbbb0