1119949 - [RTL][FM Radio] Loading animation does not flow counter-clockwise.

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::FMRadio, defect, P3)

Description

[Yeojin Chung [:YeojinC]]

Description:
When the play, next, or previous button is selected, the loading animation around the play button does not flow counter clockwise.

Pre-requisite: Headphone is plugged into the device.

Repro Steps:
1) Update a Flame device to BuildID: 20150109010206.
2) Set the device language in Arabic under Settings > Language.
3) Open FM Radio app.
4) Observe the loading animation around the play button.

Actual:
The animation flows clockwise.
  
Expected: 
Te animation flows counter-clockwise.
  
Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20150109010206
Gaia: 2c7d14040149e1f9b1bb3972ff150be0472fa6b6
Gecko: b3f84cf78dc2
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Repro frequency: 100%
See attached: video
http://youtu.be/znOg0BLFDQg

Comment 1

[Augustin Trancart [:autra]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27387

Hi,

Please find patch attached. I'm waiting for your feedback!

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8548960 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27387

The code is good (I didn't try it though) but I am not sure we should flip the animation for RTL.

Set ui-review for conformation.

Comment 3

[Dylan Oliver [:doliver]]

RTL triage: P3 -- this bug is not prioritized for inclusion in the 2.2 release.

Comment 4

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8548960 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27387

Wow, this has been waiting for too long :)
Stephany, could you please look at it or assign someone?
Thanks!

Comment 5

[Stephany Wilkes]

I am not sure where the confusion lies between the bidi pattern, the test plans and bugs being filed.

In the 2.2 spec, animation direction does not change. Please see page 14 - Player Controls. The icon direction and animation are not noted as changed for 2.2. I am resolving this invalid. 

If we change animations here to be this way, then we'll need to change them everywhere, which we don't have time to do for 2.2, which will make the OS as a whole confusing.

I'm flagging Josh on this as an example of what continues to go wrong with test plans and bugs.

Comment 6

[Stephany Wilkes]

Comment on attachment 8548960 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27387

Ui-review- set to minus because animations are not changing for 2.2, as Tim pointed out.

Comment 7

[Lancy(Leave from Mozilla)]

Remove the in-moztrap+ flag, and the corresponding TC has been modified.

Comment 8

[Josh Cheng [:josh]]

Hi Stephany,

Please understand the bug is filed by QAnalyst before Marigold and I join RTL project. It is also before 2.2 branched while the RTL scope in 2.2 decision was not made. 

I am also not sure RTL 2.2 UX spec is widely communicated among Mozilla as this seems commonly misunderstood by many people since same incorrect bug filed again and again as you mentioned.

I can work with Marigold to ensure they follow the spec from now on but I have no control over all Mozillian filing RTL bugs.

I hope the case gets better as more and more testers/developers familiar with RTL.

Thanks

Comment 9

[Augustin Trancart [:autra]]

Assigning myself as I did the patch, waiting to see if it is ok with the specs of 3.0.

Comment 10

[Stephany Wilkes]

Augustin, this icon direction and animation change will be in 2.0M, and I shared the spec with Loic for this on Friday. I assume this will also land in 3.0.

Comment 11

[Augustin Trancart [:autra]]

Stephany, ok :-) Please reopen this when you want it in master and I'll land this.