1119968 - [traceback] KeyError: 8L loading https://addons-dev.allizom.org/android

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

See http://sentry.dmz.phx1.mozilla.com/addons/addons-dev/group/22173/

STR:

Load https://addons-dev.allizom.org/en-US/android/

Exception:

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 112, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "mobility/decorators.py", line 49, in wrapper
    return normal_fn(request, *args, **kw)
  File "addons/views.py", line 345, in home
    'src': 'homepage', 'collections': collections})
  File "django/shortcuts/__init__.py", line 53, in render
    return HttpResponse(loader.render_to_string(*args, **kwargs),
  File "django/template/loader.py", line 169, in render_to_string
    return t.render(context_instance)
  File "jingo/__init__.py", line 195, in render
    return super(Template, self).render(context_dict)
  File "jinja2/environment.py", line 969, in render
    return self.environment.handle_exception(exc_info, True)
  File "jinja2/environment.py", line 742, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-olympia-dev-20150109211937-d7fb42ac96/olympia/apps/addons/templates/addons/home.html", line 8, in top-level template code
    {% set view_all = {
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-olympia-dev-20150109211937-d7fb42ac96/olympia/templates/impala/base_shared.html", line 1, in top-level template code
    {% extends 'impala/base.html' %}
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-olympia-dev-20150109211937-d7fb42ac96/olympia/templates/impala/base.html", line 161, in top-level template code
    {% block main_content %}
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-olympia-dev-20150109211937-d7fb42ac96/olympia/templates/impala/base.html", line 166, in block "main_content"
    {% block content %}{% endblock %}
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-olympia-dev-20150109211937-d7fb42ac96/olympia/apps/addons/templates/addons/home.html", line 40, in block "content"
    {% cache popular %}
  File "amo/ext.py", line 22, in _cache_support
    return sup(key, obj, timeout, extra, caller)
  File "caching/ext.py", line 74, in _cache_support
    return caching.base.cached_with(obj, caller, key, timeout)
  File "caching/base.py", line 313, in cached_with
    return cached(f, key, timeout)
  File "caching/base.py", line 292, in cached
    val = function()
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-olympia-dev-20150109211937-d7fb42ac96/olympia/apps/addons/templates/addons/home.html", line 54, in template
    {{ featured|addon_grid(src='hp-hc-featured',
  File "jingo/__init__.py", line 159, in wrapper
    t = env.get_template(template).render(context)
  File "jingo/__init__.py", line 195, in render
    return super(Template, self).render(context_dict)
  File "jinja2/environment.py", line 969, in render
    return self.environment.handle_exception(exc_info, True)
  File "jinja2/environment.py", line 742, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-olympia-dev-20150109211937-d7fb42ac96/olympia/apps/addons/templates/addons/impala/addon_grid.html", line 7, in top-level template code
    {{ addon|addon_hovercard(lazyload=first_page) }}
  File "jingo/__init__.py", line 159, in wrapper
    t = env.get_template(template).render(context)
  File "jingo/__init__.py", line 195, in render
    return super(Template, self).render(context_dict)
  File "jinja2/environment.py", line 969, in render
    return self.environment.handle_exception(exc_info, True)

Comment 1

[Mathieu Agopian [:magopian]]

Having the maemo files still in the database causes this: a link is created for the download of this file, but as the platform has been removed from the code, it raises the KeyError.

I created a database migration to remove all files with the maemo platform, which should fix this bug.

Comment 2

[Mathieu Agopian [:magopian]]

Fixed by https://github.com/mozilla/olympia/commit/de650bcba9d3b7d249038660915e069ff2ae6ead in bug 1119800

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Mathieu Agopian [:magopian] from comment #2)
> Fixed by
> https://github.com/mozilla/olympia/commit/
> de650bcba9d3b7d249038660915e069ff2ae6ead in bug 1119800

Thx; verified FIXED -- https://addons-dev.allizom.org/en-US/android/ loads just fine