sourceforge.net - Mozilla looses form data with SourceForge File Release system

RESOLVED WORKSFORME

Status

Tech Evangelism Graveyard
English US
RESOLVED WORKSFORME
16 years ago
2 years ago

People

(Reporter: Olivier Cahagne, Assigned: Doron Rosenberg (IBM))

Tracking

({regression, testcase, top100})

unspecified
x86
All
regression, testcase, top100

Details

(Whiteboard: aok, URL)

Attachments

(3 attachments)

(Reporter)

Description

16 years ago
Build ID: 2001112508 on Win2k and Linux. Regression as it does work with
Netscape 6.2 (not Mozilla 0.9.6).

Steps to reproduce:
1. Load URL
http://sourceforge.net/project/admin/editreleases.php?package_id=11770&release_id=61920&group_id=12177
2. Enter 'Test' in the 'Release Notes' box,
3. Hit 'Submit/Refresh' button,
4. Data wasn't actually accepted as 'Release Notes' is still empty,
5. SF draws errors such as:

Warning: fopen("","r") - Success in
/usr/local/sourceforge.net/www/project/admin/editreleases.php on line 50

Warning: Supplied argument is not a valid File-Handle resource in
/usr/local/sourceforge.net/www/project/admin/editreleases.php on line 50

Warning: fopen("","r") - Success in
/usr/local/sourceforge.net/www/project/admin/editreleases.php on line 61

Warning: Supplied argument is not a valid File-Handle resource in
/usr/local/sourceforge.net/www/project/admin/editreleases.php on line 61

Expected results: working flawlessly, it works with IE6, Netscape 4.76, Netscape
6.2, not Mozilla 0.9.6 and later.

You have to be an admin to access above URL, if you have a SF account, let me
know, I'll give you admin rights for this bug. Otherwise, we can also setup a
dummy project to access this File Release form.
(Reporter)

Comment 1

16 years ago
Created attachment 59195 [details]
HTTP transaction (via sniffer) with Netscape 4.79 on Linux
(Reporter)

Comment 2

16 years ago
Created attachment 59196 [details]
HTTP transaction (via sniffer) with Mozilla 2001112508

With Mozilla, two items are missing from the transaction:

[...]
-----------------------------104195057818304962681319551376

Content-Disposition: form-data; name="uploaded_notes"; filename=""




-----------------------------104195057818304962681319551376

Content-Disposition: form-data; name="uploaded_changes"; filename=""


[...]
(Reporter)

Comment 3

16 years ago
Both missing fields are these in HTML source code:

<input type="file" name="uploaded_changes" size="30">
 and
<input type="file" name="uploaded_notes" size="30">

So I guess a testcase would easily follow, perhaps it's even a dupe of an
already reported bug.

Keywords: regression
(Reporter)

Comment 4

16 years ago
Created attachment 59307 [details]
Testcase with input type=file incorrectly transmitted by Mozilla

Click on the attachment, then enter something in the textarea ('test' for
example) then click Submit.
Either with a sniffer where you can see latest Mozilla build (2001112603) does
not transmit the 'input type=file', or with the results from the POST where you
can see the var is null.
With IE6 or Netscape 4.76, var is 'none' and a sniffer shows it's transmitted.
(Reporter)

Comment 5

16 years ago
Changing Severity to blocker as it's one of the biggest Web sites, and this
behaviour has obviously changed since some weeks and might block many other Web
sites.
Severity: major → blocker
Keywords: testcase, top100
(Reporter)

Comment 6

16 years ago
Marking dupe of bug 111963.

*** This bug has been marked as a duplicate of 111963 ***
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → DUPLICATE

Comment 7

16 years ago
Note that SourceForge ought not to rely on empty file controls being successful.
See http://www.w3.org/TR/html4/interact/forms.html#h-17.13.2, which says:
- "The current value of a file select is a list of one or more file names. Upon
submission of the form, the contents of each file are submitted with the rest of
the form data."
- "If a control doesn't have a current value when the form is submitted, user
agents are not required to treat it as a successful control."
Taken together, these statements allow browsers to treat a file select that
specifies no file names as unsuccessful, that is, to omit them from the
submitted data.

In other words, Mozilla's behavior is allowable, if inconvenient. I gather that
 it will be changed back, but other browsers that comply with HTML 4.01 may not.
If SourceForge is intended to be robust, it should accommodate the absence of
data for empty file inputs.

Comment 8

16 years ago
should we make this an evang then?
(Reporter)

Comment 9

16 years ago
I'd vote for both Evangelism and revert to original behaviour because it might
have broken many more sites, especially in an Intranet environment, where "input
type=file" are used a lot.

Comment 10

16 years ago
well bug 111963 is going to fix the issue on mozilla's side and I'll reopen this
and send to tech evangelism then
Status: RESOLVED → REOPENED
Component: HTML Form Controls → English: US
Product: Browser → Tech Evangelism
Resolution: DUPLICATE → ---
Version: other → unspecified
(Reporter)

Comment 11

16 years ago
now wfm using build 2001112903 on Win2k.
Severity back to Normal, still a Tech Evangelism bug though.
Severity: blocker → normal

Updated

16 years ago
Status: REOPENED → ASSIGNED
Target Milestone: --- → Jan
(Reporter)

Comment 12

16 years ago
SourceForge now has a ticket for this issue:
http://sourceforge.net/tracker/index.php?func=detail&aid=495432&group_id=1&atid=200001

Comment 13

16 years ago
aok
Summary: Mozilla looses form data with SourceForge File Release system → sourceforge.net - Mozilla looses form data with SourceForge File Release system

Updated

16 years ago
Whiteboard: aok

Comment 14

16 years ago
grr, sorry for all the spam
Assignee: rods → doronr
Status: ASSIGNED → NEW
QA Contact: madhur → zach
(Reporter)

Comment 15

15 years ago
SF will not fix the issue, see the ticket.
Status: NEW → RESOLVED
Last Resolved: 16 years ago15 years ago
Resolution: --- → WONTFIX

Comment 16

15 years ago
This appears to have been fixed in bug 111963 and it not a wontfix if we changed
our behavior -> reopen.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---

Comment 17

15 years ago
wolruf, does this problem still occur for you?
(Reporter)

Comment 18

15 years ago
Bob, it works for me.
(Reporter)

Comment 19

15 years ago
Please reopen if you disagree.
Status: REOPENED → RESOLVED
Last Resolved: 15 years ago15 years ago
Resolution: --- → WORKSFORME
Product: Tech Evangelism → Tech Evangelism Graveyard
You need to log in before you can comment on or make changes to this bug.