1120050 - Expose Skia scaler internals for use by downscale-during-decode

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Seth Fowler [:seth] [:s2h]]

Downscale-during-decode needs to work in a streaming fashion, which the public Skia scaler API (the one we use for high-quality scaling) doesn't support. To implement downscale-during-decode, we need to expose some internal features of the Skia scaler API.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Expose Skia scaler internals for use by downscale-during-decode

Here's the patch. This patch shouldn't change any functionality; it just moves
internal Skia code that we need for downscale-during-decode into header files
and otherwise makes it public. Purely refactoring.

Comment 2

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8546979 [details] [diff] [review]
Expose Skia scaler internals for use by downscale-during-decode

rubber stamp this. Jeff can do post landing review.

Comment 3

[Seth Fowler [:seth] [:s2h]]

Pushed:

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/3ff6c190426e

Based on this try job, which is looking pretty green:

https://tbpl.mozilla.org/?tree=Try&rev=f3f4d04d1fbe

Comment 4

[Carsten Book [:Tomcat]]

sorry had to back this out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=5344852&repo=mozilla-inbound

Comment 5

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/projects/cypress/rev/965b5028e41e

Comment 6

[Seth Fowler [:seth] [:s2h]]

Attachment: Expose Skia scaler internals for use by downscale-during-decode

This needed a rebase.

Comment 7

[Seth Fowler [:seth] [:s2h]]

Should be ready to go now. Pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e00afa8044c3

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e00afa8044c3

Comment 9

[Yuan Pengfei]

Comment on attachment 8550071 [details] [diff] [review]
Expose Skia scaler internals for use by downscale-during-decode

Review of attachment 8550071 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/image_operations.h
@@ +183,5 @@
> +    return 0.0f;  // Outside of the window.
> +  if (x > -std::numeric_limits<float>::epsilon() &&
> +      x < std::numeric_limits<float>::epsilon())
> +    return 1.0f;  // Special case the discontinuity at the origin.
> +  float xpi = x * static_cast<float>(M_PI);

Missing #include "mozilla/Constants.h"