1120099 - bug763440.js has wrong reportCompare description

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

https://dxr.mozilla.org/mozilla-central/source/js/src/jit-test/tests/basic/bug763440.js#10
> reportCompare(true, eval++, "Function.prototype.isGenerator present");
it does not describe what the test does.
(not sure it's intended or not though, since it was sec-critical)

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Change dummy description string for reportCompare to avoid confusion.

This bug was derived from bug 1119777.

Since Function.prototype.isGenerator is non-standard and might be removed near future.
Also it's not related to this test, so it might be better to change this description to some other string.

I guess the length of the string does not matter, am I right?

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8548069 [details] [diff] [review]
Change dummy description string for reportCompare to avoid confusion.

Review of attachment 8548069 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah this shouldn't matter.

Comment 3

[Tooru Fujisawa [:arai]]

Thanks :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca2c472d1aae

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ca2c472d1aae