Closed Bug 1120125 Opened 7 years ago Closed 7 years ago

compile error in nsNTLMAuthModule.cpp (big endian)

Categories

(Core :: Networking, defect)

Other
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: stevensn, Assigned: stevensn)

References

Details

Attachments

(1 file)

nsNTLMAuthModule fails to build on big endian with

src/security/manager/ssl/src/nsNTLMAuthModule.cpp:593:74: error: expected ?(? before ?domainPtr?
     WriteUnicodeLE((void *) domainPtr, reinterpret_cast<const uint16_t*> domainPtr,

This is a result of f09bfc814171  for bug 423758
Attached patch fix_1120125.diffSplinter Review
Fixes the compiler error.
Note: char can be signed or unsigned depending on the platform.
Attachment #8547112 - Flags: review?(dkeeler)
Comment on attachment 8547112 [details] [diff] [review]
fix_1120125.diff

Review of attachment 8547112 [details] [diff] [review]:
-----------------------------------------------------------------

Good call. Out of curiosity, what platforms do we support that are big-endian?
Attachment #8547112 - Flags: review?(dkeeler) → review+
No tier-1 platforms are big endian but the community including downstream OS distributions regularly build firefox on sparc and powerpc.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c31dc4144a13
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8547112 [details] [diff] [review]
fix_1120125.diff

Approval Request Comment
[Feature/regressing bug #]: bug 423758
[User impact if declined]: Firefox will not build on big endian platforms
[Describe test coverage new/current, TBPL]: Tested on m-c
[Risks and why]: Low risk, changing code in a #ifdef that is NPOTB-tier1
[String/UUID change made/needed]:
Attachment #8547112 - Flags: approval-mozilla-aurora?
Comment on attachment 8547112 [details] [diff] [review]
fix_1120125.diff

Aurora+
Attachment #8547112 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.