1120125 - compile error in nsNTLMAuthModule.cpp (big endian)

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Steve Singer (:stevensn)]

nsNTLMAuthModule fails to build on big endian with

src/security/manager/ssl/src/nsNTLMAuthModule.cpp:593:74: error: expected ?(? before ?domainPtr?
     WriteUnicodeLE((void *) domainPtr, reinterpret_cast<const uint16_t*> domainPtr,

This is a result of f09bfc814171  for bug 423758

Comment 1

[Steve Singer (:stevensn)]

Attachment: fix_1120125.diff

Fixes the compiler error.
Note: char can be signed or unsigned depending on the platform.

Comment 2

[Steve Singer (:stevensn)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=742375dde5c8

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8547112 [details] [diff] [review]
fix_1120125.diff

Review of attachment 8547112 [details] [diff] [review]:
-----------------------------------------------------------------

Good call. Out of curiosity, what platforms do we support that are big-endian?

Comment 4

[Steve Singer (:stevensn)]

No tier-1 platforms are big endian but the community including downstream OS distributions regularly build firefox on sparc and powerpc.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c31dc4144a13

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c31dc4144a13

Comment 7

[Steve Singer (:stevensn)]

Comment on attachment 8547112 [details] [diff] [review]
fix_1120125.diff

Approval Request Comment
[Feature/regressing bug #]: bug 423758
[User impact if declined]: Firefox will not build on big endian platforms
[Describe test coverage new/current, TBPL]: Tested on m-c
[Risks and why]: Low risk, changing code in a #ifdef that is NPOTB-tier1
[String/UUID change made/needed]:

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8547112 [details] [diff] [review]
fix_1120125.diff

Aurora+

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/879df92f4003