1120135 - Invitees list in Room details is not correctly updated if an invitee contact is removed from the Agenda

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

Reproduced with flame device over latest 2.0 FxOS version and master Loop version:

Prerequisite: Users A and B are registered in Loop and User A has Contact B included in his Agenda
STR:
1.) User A creates a Room1 and shares it with user B. In the Room List of Device A appears the Room1 and Contact B as an entry of Room list. Besides in the Room1 details, Contact B is shown in the Invitees list.
2.) Remove Contact B from the Agenda of Device A

Actual Result:
In the Room List of Device A appears the Room1 and the corresponding identity of Contact B (e-mail or telephone number) as an entry of Room list but the Invitees list still shows the Contact B name.

Expected Result: 
In the Room List of Device A should appear the corresponding identity of Contact B (e-mail or telephone number) and NOT the contact B name as Contact B has been deleted from the Agenda.

Comment 1

[Cristian Rodriguez (:crdlc)]

Hi Paco, Borja

   AFAIK we show the list directly with the name which was stored on DB. We could have two possible solutions:

1) DB updates the invitees list when a contact changes in mozContact, etc... It would be ideal but I think that it is very difficult and risky at this point.

2) Maybe being more conservative we could update each item in this list (common cases between 1..5 registers thought) with ContactsHelper.find() after rendering the list. 

I don't know how you guys see this issue. What do you think?

Comment 2

[Borja Salguero [:borjasalguero]]

In this case I would go for the 2nd option, because the first one is not going to fit with the deadline we have. I'll try to sort this out and create a patch asap. Thanks!

Comment 3

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 4

[Paco Rampas [:paco]]

With the patch attached we can update a contact info and the changes are reflected on the list of invitees of a room. But there is an issue if you delete a contact and then you create a new user with the same identity of the deleted user, then appears the issue only if you share a room with the new user in a room with the deleted user.

STR:
0- Create a user with name "A" and tel or email "XXX".
1- Open Fx Hello and create a room.
2- Share the room with the contact "A" tapping on the button "pick a contact". 
3- Open the contacts app and delete the contact "A".
4- Create a contact "B" with the same telephone number or email of "A".
5- Now, go to Fx Hello and share the room with "B".

Result:
We have a list of two invitees.

Expected:
Have only one item because Contact "A" and contact "B" have the same Fx Hello identity.

What is the better way to fix it?

Comment 5

[Borja Salguero [:borjasalguero]]

Comment on attachment 8551241 [details] [review]
patch in github

Great job Paco!! Thanks for the patch!

Comment 6

[Paco Rampas [:paco]]

merged: f8e0c8d831cbc23d169f3b165b07b2d55756c668

:D

Comment 7

[Loli (:lolimartinezcr)]

Tested and it is working. Now in the Room List of Device A appears the corresponding identity of Contact B (e-mail or telephone number) and NOT the contact B name as Contact B has been deleted from the Agenda.

FireE
Commercial version 2.0
Loop version:1.1.1/d4d6d37