Closed
Bug 1120141
Opened 10 years ago
Closed 9 years ago
Investigate why canvas tests fail if PNG images are allowed to have a B8G8R8X8 first frame
Categories
(Core :: Graphics: Canvas2D, defect)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: seth, Assigned: tnikkel)
References
Details
Attachments
(1 file)
|
1.71 KB,
patch
|
eflores
:
review+
|
Details | Diff | Splinter Review |
Canvas tests fail if PNG images are allowed to have a B8G8R8X8 first frame. Somewhere some code is wrongly assuming or requiring B8G8R8A8. We should fix this.
A specific example of a test that fails is the web platform test |2d.drawImage.broken.html|.
I hacked around this in bug 1117607 by forcing PNG first frames to be B8G8R8A8 in nsPNGDecoder::CreateFrame. We should remove that hack once we fix this.
|
Assignee | |
Comment 1•9 years ago
|
||
This doesn't appear to be a problem anymore.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c733eabfdee
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fc138128ec0
Assignee: seth → tnikkel
Attachment #8722823 -
Flags: review?(edwin)
Attachment #8722823 -
Flags: review?(edwin) → review+
|
||
Comment 3•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•