1120179 - [in-content preferences] orange stripe is missing on main navigation

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Sören Hentzschel]

Attachment: screenshot

The orange stripe is missing on the active menu item in the new in-content preferences of Thunderbird.

Operating System: OS X 10.10.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: MozReview Request: bz://1120179/Paenglab

Comment 2

[Richard Marti (:Paenglab)]

/r/2345 - Bug 1120179 - Fix the in-content prefs styling. Fixes also bug 1120181, bug 1120183 and bug 1120187. r=josiah

Pull down this commit:

hg pull review -r 8de4586c37f8d0f563f783a5d781b30549e63733

Comment 3

[Richard Marti (:Paenglab)]

Sören, please could you test the try build (1) to check if the issues of all bugs above are fixed?

(1) https://ftp-ssl.mozilla.org/pub/mozilla.org/thunderbird/try-builds/[e-mail]-d06150dc29e5

Comment 4

[Sören Hentzschel]

Yes, the issues of bug 1120179, bug 1120181, bug 1120183 and bug 1120187 are fixed with this try build.

Thanks for your work on the new preferences!

Comment 5

[Richard Marti (:Paenglab)]

Thanks for testing.

Comment 6

[Josiah Bruner [:jsbruner]]

https://reviewboard.mozilla.org/r/2343/#review1561

Ship It!

Comment 7

[Josiah Bruner [:jsbruner]]

https://reviewboard.mozilla.org/r/2345/#review1563

Ship It!

Comment 8

[Magnus Melin [:mkmelin]]

(Doesn't seem many people know how to check in from reviewboard, so this is still sitting here.)

Comment 9

[Richard Marti (:Paenglab)]

Attachment: Patch for check-in

Okay, here is the same patch for check-in.

Comment 10

[Philipp Kewisch [:Fallen][☁️📆]]

https://hg.mozilla.org/comm-central/rev/7e5dc96427d6

Comment 12

[Richard Marti (:Paenglab)]

Attachment: MozReview Request: Bug 1120179 - Fix the in-content prefs styling. Fixes also bug 1120181, bug 1120183 and bug 1120187. r=josiah