11202 - Frame resizing causes repaint problems

Status: VERIFIED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P3)

Description

[Mats Palmgren (inactive)]

To repeat:
1. load http://www.aricia.fr/
2. grab and drag any of the frame dividers and resize frame.

What happens:
Window is not repainted properly (I have a screenshot if you want)

Version and OS:
build 1999-08-02-13-M9 on Windows 98.

Comment 1

[karnaze (gone)]

Reassigning to Eric.

Comment 2

[Eric Pollmann]

Attachment: Test case

Comment 3

[Eric Pollmann]

I can find no resizable frames on this site.

To test the bug, I created an attachment.  Resizing this on Windows NT causes no
visible artifacts.

1) What exact URL are you experiencing this on?
2) Please attach the screenshot.

Thanks!

Comment 4

[Mats Palmgren (inactive)]

The original site (http://www.aricia.fr/) has been completly redesigned since I
reported this bug, but I have found a new page that has the same problems.
I don't see any problems in the attached testcase either, it seems to only
appear when there are both frames divided horizontally and vertically.
Changing URL. Bug still occurs in apprunner 1999-09-25-09-M11 on Windows NT4sp5.
Attaching a snapshot of the new URL. (I'll see if I can dig up the old one too).

Comment 5

[Mats Palmgren (inactive)]

Attachment: snapshot of repaint problem at java.sun.com

Comment 6

[Eric Pollmann]

Ah, I see it now!  What I'm seeing is: When I slide the vertical divider left,
the two left frames shrink twice the needed amount. When I slide the vertical
divider right, the two left frames grow twice the needed amount, and paint on
top of the divider and right frame.

This looks like a math error somewhere, shouldn't be too bad to track it down
(famous last words.)  I'm attaching a test case.

Comment 7

[Eric Pollmann]

Attachment: simple page

Comment 8

[Eric Pollmann]

Attachment: reduced test case

Comment 9

[Eric Pollmann]

Attachment: reduced test case

Comment 10

[rubydoo123]

assigning to Petersen

Comment 11

[ekrock's old account (dead)]

Moving to M16.

Comment 12

[ekrock's old account (dead)]

Bulk moving [testcase] code to new testcase keyword. Sorry for the spam!

Comment 13

[Jacob Kjome]

I've found another situation where resizing causes paint problems that I don't
think has been addressed here.

using Win32 build: 2000031008

Steps to reproduce:
1. go to http://www.syntegra.com

2. drag the right bottom corner of the browser to the left so that the
horizontal space shrinks.  Do this until you see a scrollbar.

3. grab the scrollbar and scroll it to the right (any distance, but try moving
it all the way to the right the first time).

4. Now go back to the bottom right corner and drag the window so that the
horizontal space gets bigger.

5. You should now see a white area at the right side of the window. The width of
the white space seems to correspond to how far the scrollbar was scrolled to the
right.  The window just isn't being repainted until you either refresh or you
repeat step 2

Jake

Comment 14

[Eric Pollmann]

[e-mail] that was a great catch, thanks.  In fact, this happens on any page
even if there are no framesets.  I've filed a new bug for you:

http://bugzilla.mozilla.org/show_bug.cgi?id=32679

This bug will remain about the problem described earlier, thanks!

Comment 15

[Eric Pollmann]

I think I have a fix for this.  Still testing.  It turns out that if one of the 
frameset children that is being resized is actually a frameset, it is resized in 
two places in the code (once in ::MouseDrag and once in ::ReflowPlaceChild).  I 
removed the extra one (ReflowPlaceChild) and the bug was fixed.  Need to do some 
testing, but it looks very promising.

Comment 16

[Eric Pollmann]

Fix checked in.  To verify, go to Viewer debug test case 9:

resource:/res/samples/test9.html

Grab the divider bar between the top and two bottom frames.
Drag it upwards or downwards.  Though the resizing will be slow (this is due to 
reflow being slow for such large documents), resizing should work now.

There is also a reduced test case on this bug.  Draging the vertical resize bar 
should work on that now too.  Thanks!

Comment 17

[Eric Pollmann]

*** Bug 32427 has been marked as a duplicate of this bug. ***

Comment 18

[Eric Pollmann]

*** Bug 29781 has been marked as a duplicate of this bug. ***

Comment 19

[Chris Petersen]

Fixed in the April 26th build.