1120235 - promise Resolver [[Call]] should return undefined, but returns resolver itself

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mark S. Miller]

> var r;
> var p = new Promise(function(rr) { r = rr; });
> r(88) == r;
true

Comment 1

[Till Schneidereit [:till]]

Moving to the DOM component because our Promise implementation hasn't yet been moved to the JS engine (which doesn't yet implement job queues).

Comment 2

[Boris Zbarsky [:bzbarsky]]

Yay, JSAPI strikes again.  In JSAPI, returning the function itself is the default behavior unless you go out of your way to return something else.  :(

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Various promise resolve/reject functions should actually return undefined instead of ending up accidentally returning their callee

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8547572 [details] [diff] [review]
Various promise resolve/reject functions should actually return undefined instead of ending up accidentally returning their callee

Review of attachment 8547572 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/promise/tests/mochitest.ini
@@ +4,5 @@
>  [test_promise.html]
>  [test_promise_utils.html]
>  [test_resolve.html]
>  [test_abortable_promise.html]
> +[test_resolver_return_value.html]

Nit: I prefer test lists to be sorted. I'm not sure how abortable promise broke the convention, could you fix that when landing? Thanks!

Comment 5

[Boris Zbarsky [:bzbarsky]]

Done and https://hg.mozilla.org/integration/mozilla-inbound/rev/02fb8f978e91

Thanks for the quick review!

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/02fb8f978e91