1120239 - Warnings-as-errors breaks compilation in MediaStreamSource.cpp

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[Juan Gomez [:_AtilA_] (CET/CEST)]

Since bug 1073003 landed, we are having build bustages con Peak.

This is the error:

MediaOmxDecoder.o
In file included from ../../../dist/system_wrappers/stagefright/DataSource.h:3:0,
                 from /media/data_disk/b2g/build.peak/gecko/dom/media/omx/MediaStreamSource.h:12,
                 from /media/data_disk/b2g/build.peak/gecko/dom/media/omx/MediaOmxCommonReader.cpp:13:
/media/data_disk/b2g/build.peak/frameworks/base/include/media/stagefright/DataSource.h:63:21: error: 'virtual ssize_t android::DataSource::readAt(off64_t, void*, size_t, int)' was hidden [-Werror=overloaded-virtual]
     virtual ssize_t readAt(off64_t offset, void *data, size_t size, int buffer_flag) { return readAt(offset, data, size); }
                     ^
In file included from /media/data_disk/b2g/build.peak/gecko/dom/media/omx/MediaOmxCommonReader.cpp:13:0:
/media/data_disk/b2g/build.peak/gecko/dom/media/omx/MediaStreamSource.h:31:19: error:   by 'android::MediaStreamSource::readAt' [-Werror=overloaded-virtual]
   virtual ssize_t readAt(off_t offset, void *data, size_t size) {
                   ^
cc1plus: all warnings being treated as errors

Comment 1

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: Disable overloaded-virtual warnings for OMX codec via moz.build

Comment 2

[Botond Ballo [:botond]]

In bug 1073081 and bug 1073003, I fixed -Woverloaded-virtual warnings without disabling them by renaming the new method in the derived class.

Comment 3

[(no longer active)]

Comment on attachment 8547209 [details] [diff] [review]
Disable overloaded-virtual warnings for OMX codec via moz.build

Review of attachment 8547209 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, we should fix the code here.  This warning is super useful!

Comment 4

[Juan Gomez [:_AtilA_] (CET/CEST)]

Ok, Geeksphone guys updated the Framework base platform (including media), so there's no more errors :)