Warnings-as-errors breaks compilation in MediaStreamSource.cpp

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
4 years ago
4 years ago

People

(Reporter: _AtilA_, Assigned: _AtilA_)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Since bug 1073003 landed, we are having build bustages con Peak.

This is the error:

MediaOmxDecoder.o
In file included from ../../../dist/system_wrappers/stagefright/DataSource.h:3:0,
                 from /media/data_disk/b2g/build.peak/gecko/dom/media/omx/MediaStreamSource.h:12,
                 from /media/data_disk/b2g/build.peak/gecko/dom/media/omx/MediaOmxCommonReader.cpp:13:
/media/data_disk/b2g/build.peak/frameworks/base/include/media/stagefright/DataSource.h:63:21: error: 'virtual ssize_t android::DataSource::readAt(off64_t, void*, size_t, int)' was hidden [-Werror=overloaded-virtual]
     virtual ssize_t readAt(off64_t offset, void *data, size_t size, int buffer_flag) { return readAt(offset, data, size); }
                     ^
In file included from /media/data_disk/b2g/build.peak/gecko/dom/media/omx/MediaOmxCommonReader.cpp:13:0:
/media/data_disk/b2g/build.peak/gecko/dom/media/omx/MediaStreamSource.h:31:19: error:   by 'android::MediaStreamSource::readAt' [-Werror=overloaded-virtual]
   virtual ssize_t readAt(off_t offset, void *data, size_t size) {
                   ^
cc1plus: all warnings being treated as errors
(Assignee)

Comment 1

4 years ago
Created attachment 8547209 [details] [diff] [review]
Disable overloaded-virtual warnings for OMX codec via moz.build
Assignee: nobody → atilag
Attachment #8547209 - Flags: review?(ehsan)
In bug 1073081 and bug 1073003, I fixed -Woverloaded-virtual warnings without disabling them by renaming the new method in the derived class.

Comment 3

4 years ago
Comment on attachment 8547209 [details] [diff] [review]
Disable overloaded-virtual warnings for OMX codec via moz.build

Review of attachment 8547209 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, we should fix the code here.  This warning is super useful!
Attachment #8547209 - Flags: review?(ehsan) → review-
(Assignee)

Comment 4

4 years ago
Ok, Geeksphone guys updated the Framework base platform (including media), so there's no more errors :)
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.