1120272 - Fix the situation with jemalloc + aligned allocation + Windows

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Nicholas Nethercote [inactive]]

We expose posix_memalign from jemalloc on Windows, but fail to set HAVE_POSIX_MEMALIGN. This should be fixed.

Also, we use the Windows-only _aligned_malloc and _aligned_free functions but we don't expose them from jemalloc. So those calls might be going to the system allocator instead of jemalloc. This should also be fixed.

Comment 1

[Mike Hommey [:glandium]]

(In reply to Nicholas Nethercote [:njn] from comment #0)
> We expose posix_memalign from jemalloc on Windows, but fail to set
> HAVE_POSIX_MEMALIGN. This should be fixed.

So, one glitch with this is that even if jemalloc exposes it and Windows can use it, code that relies on HAVE_POSIX_MEMALIGN has the problem that it doesn't get a declaration from headers. While it seems to build and work from a try build (probably using an implicit declaration), it feels to me this needs more thought and possibly involve wrapper headers to actually add the declaration.

> Also, we use the Windows-only _aligned_malloc and _aligned_free functions
> but we don't expose them from jemalloc. So those calls might be going to the
> system allocator instead of jemalloc. This should also be fixed.

This can be fixed independently.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Expose _aligned_alloc and _aligned_free from mozglue

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/93f526d85b47

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/93f526d85b47

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:glandium, maybe it's time to close this bug?

Comment 7

[Mike Hommey [:glandium]]

This is still something that needs addressing.

Comment 8

[Mike Hommey [:glandium]]

Let's consider this fixed, and the remaining issues can be addressed in bug 1842582