Closed
Bug 1120288
Opened 11 years ago
Closed 11 years ago
SocialService.jsm shouldn't be using AddonManagerPrivate.notifyAddonChanged()
Categories
(Firefox Graveyard :: SocialAPI, defect)
Tracking
(firefox39 fixed)
RESOLVED
FIXED
Firefox 39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: Unfocused, Assigned: mixedpuppy)
References
Details
Attachments
(1 file)
|
1.06 KB,
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
Not sure how I missed this in my driveby review of bug 755126.... SocialService.jsm inappropriately calls AddonManagerPrivate.notifyAddonChanged() when a social provider gets disabled. It shouldn't.
The notifyAddonChanged() API is meant to be used when only one add-on of a given add-on type is meant to be enabled at a time - such as themes.
Thankfully, the usage here is harmless, since no code is listening for addonChanged for that add-on type. But the usage is still inappropriate and should be removed (doubly so because I want to remove that API).
|
Assignee | |
Comment 1•11 years ago
|
||
Did a quick test (removing that line, running browser/base/content/test/social/browser_addons.js), seems like that line can just be removed.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Assignee: nobody → mixedpuppy
Attachment #8574966 -
Flags: review?(bmcbride)
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 8574966 [details] [diff] [review]
remove unnecessary notifyAddonChanged call
Review of attachment 8574966 [details] [diff] [review]:
-----------------------------------------------------------------
I wish all changes were this simple.
Attachment #8574966 -
Flags: review?(bmcbride) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
|
||
Updated•7 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•