SocialService.jsm shouldn't be using AddonManagerPrivate.notifyAddonChanged()

RESOLVED FIXED in Firefox 39

Status

()

Firefox
SocialAPI
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Unfocused, Assigned: mixedpuppy)

Tracking

Trunk
Firefox 39
x86_64
Windows 8.1
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

Not sure how I missed this in my driveby review of bug 755126.... SocialService.jsm inappropriately calls AddonManagerPrivate.notifyAddonChanged() when a social provider gets disabled. It shouldn't.

The notifyAddonChanged() API is meant to be used when only one add-on of a given add-on type is meant to be enabled at a time - such as themes.

Thankfully, the usage here is harmless, since no code is listening for addonChanged for that add-on type. But the usage is still inappropriate and should be removed (doubly so because I want to remove that API).
(Assignee)

Comment 1

3 years ago
Did a quick test (removing that line, running browser/base/content/test/social/browser_addons.js), seems like that line can just be removed.
(Assignee)

Comment 2

3 years ago
Created attachment 8574966 [details] [diff] [review]
remove unnecessary notifyAddonChanged call
Assignee: nobody → mixedpuppy
Attachment #8574966 - Flags: review?(bmcbride)
Comment on attachment 8574966 [details] [diff] [review]
remove unnecessary notifyAddonChanged call

Review of attachment 8574966 [details] [diff] [review]:
-----------------------------------------------------------------

I wish all changes were this simple.
Attachment #8574966 - Flags: review?(bmcbride) → review+
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/1b014199558b
https://hg.mozilla.org/mozilla-central/rev/1b014199558b
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
You need to log in before you can comment on or make changes to this bug.