Closed Bug 1120300 Opened 5 years ago Closed 5 years ago

export WritingModes.h as mozilla/WritingModes.h

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: heycam, Assigned: heycam)

Details

Attachments

(1 file)

I think WritingModes.h should be exported such that it needs to be included with

#include "mozilla/WritingModes.h"

to be consistent with other header files that define things in the mozilla namespace.
Yes.  We don't enforce this for headers that aren't exported, but for ones that are, we should use EXPORTS.mozilla, etc.
Attached patch patchSplinter Review
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8583580 - Flags: review?(jfkthame)
Attachment #8583580 - Attachment is patch: true
Comment on attachment 8583580 [details] [diff] [review]
patch

Review of attachment 8583580 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, provided it all builds everywhere. :) (I see you've sorted the #includes, which *should* be fine but if we have unexpected interdependencies, who knows.....)

::: layout/generic/JustificationUtils.h
@@ +7,5 @@
>  #ifndef mozilla_JustificationUtils_h_
>  #define mozilla_JustificationUtils_h_
>  
>  #include "mozilla/Attributes.h"
> +#include "nsCoord.h"

Interesting... so I guess the reordering of #includes in nsLineLayout.h did give you a build failure!
Attachment #8583580 - Flags: review?(jfkthame) → review+
(In reply to Jonathan Kew (:jfkthame) from comment #3)
> Interesting... so I guess the reordering of #includes in nsLineLayout.h did
> give you a build failure!

Indeed it did. :)
https://hg.mozilla.org/mozilla-central/rev/56f423225af5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.