Add rewind, fast-forward and set current time to the animation inspector panel

RESOLVED FIXED in Firefox 39

Status

()

Firefox
Developer Tools: Animation Inspector
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: pbro, Assigned: pbro)

Tracking

unspecified
Firefox 39
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
The animation inspector panel in the inspector sidebar only allows to play/pause animations for now.

When bug 1110762 and bug 1120339 land, we will have what it takes to add:

- rewind and fast-forward buttons,
- the ability to drag/drop the timeline to set the time,
- a playback rate selection menu (with entries such as 0.1x, 0.5x, 1x, 2x).
(Assignee)

Updated

3 years ago
Blocks: 985861
Depends on: 1110762, 1120339
(Assignee)

Updated

3 years ago
Blocks: 1120900
(Assignee)

Updated

3 years ago
Assignee: nobody → pbrosset
(Assignee)

Comment 1

3 years ago
Let's make this bug solely about making animations' currentTime settable through the animation inspector.
I'll file another bug for the playback rate.
No longer depends on: 1120339
Summary: Add rewind, fast-forward, playback rate selection and set current time to the animation inspector panel → Add rewind, fast-forward and set current time to the animation inspector panel
(Assignee)

Comment 2

3 years ago
Created attachment 8579286 [details]
MozReview Request: bz://1120343/pbrosset

/r/5585 - Bug 1120343 - 1 - Allow setting animations' currentTime by clicking/dragging the timeline
/r/5587 - Bug 1120343 - 2 - Add rewind and fast-forward buttons to animation player widgets
/r/5589 - Bug 1120343 - 3 - Tests for the current time control in the animation panel

Pull down these commits:

hg pull review -r 7545a8a1d725f98aa0cdb3ea64f6417f86e012ea
Attachment #8579286 - Flags: review?(mratcliffe)
(Assignee)

Comment 3

3 years ago
In patch part 3, on top of adding tests for this new feature, I have:
- moved 2 generic enough frame-script listeners to browser/devtools/shared/frame-script-utils.js (which is our common devtools frame-script),
- gotten rid of CPOWs altogether by removing the getNode function from head.js, and instead, passing selectors to the frame script message listeners when needed.
(Assignee)

Comment 4

3 years ago
Also, I have no ideas why reviewboard considers part 3 as discarded ... What happened was I pushed to reviewboard once, realized I missed something, so I discarded the whole review (not just one part, I think), and then pushed again with the changes.
Comment on attachment 8579286 [details]
MozReview Request: bz://1120343/pbrosset

https://reviewboard.mozilla.org/r/5583/#review4593

Ship It!
Attachment #8579286 - Flags: review?(mratcliffe) → review+
https://hg.mozilla.org/mozilla-central/rev/39871e383356
https://hg.mozilla.org/mozilla-central/rev/220cb8916ff4
https://hg.mozilla.org/mozilla-central/rev/8eee838b8c46
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
(Assignee)

Comment 13

3 years ago
Comment on attachment 8579286 [details]
MozReview Request: bz://1120343/pbrosset
Attachment #8579286 - Attachment is obsolete: true
Attachment #8619102 - Flags: review+
Attachment #8619103 - Flags: review+
Attachment #8619104 - Flags: review+
(Assignee)

Comment 14

3 years ago
Created attachment 8619102 [details]
MozReview Request: Bug 1120343 - 1 - Allow setting animations' currentTime by clicking/dragging the timeline
(Assignee)

Comment 15

3 years ago
Created attachment 8619103 [details]
MozReview Request: Bug 1120343 - 2 - Add rewind and fast-forward buttons to animation player widgets
(Assignee)

Comment 16

3 years ago
Created attachment 8619104 [details]
MozReview Request: Bug 1120343 - 3 - Tests for the current time control in the animation panel
(Assignee)

Updated

2 years ago
Component: Developer Tools: Inspector → Developer Tools: Animation Inspector
You need to log in before you can comment on or make changes to this bug.