1120343 - Add rewind, fast-forward and set current time to the animation inspector panel

Status: RESOLVED FIXED

(DevTools :: Inspector: Animations, defect)

Description

[Patrick Brosset <:pbro>]

The animation inspector panel in the inspector sidebar only allows to play/pause animations for now.

When bug 1110762 and bug 1120339 land, we will have what it takes to add:

- rewind and fast-forward buttons,
- the ability to drag/drop the timeline to set the time,
- a playback rate selection menu (with entries such as 0.1x, 0.5x, 1x, 2x).

Comment 1

[Patrick Brosset <:pbro>]

Let's make this bug solely about making animations' currentTime settable through the animation inspector.
I'll file another bug for the playback rate.

Comment 2

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: bz://1120343/pbrosset

/r/5585 - Bug 1120343 - 1 - Allow setting animations' currentTime by clicking/dragging the timeline
/r/5587 - Bug 1120343 - 2 - Add rewind and fast-forward buttons to animation player widgets
/r/5589 - Bug 1120343 - 3 - Tests for the current time control in the animation panel

Pull down these commits:

hg pull review -r 7545a8a1d725f98aa0cdb3ea64f6417f86e012ea

Comment 3

[Patrick Brosset <:pbro>]

In patch part 3, on top of adding tests for this new feature, I have:
- moved 2 generic enough frame-script listeners to browser/devtools/shared/frame-script-utils.js (which is our common devtools frame-script),
- gotten rid of CPOWs altogether by removing the getNode function from head.js, and instead, passing selectors to the frame script message listeners when needed.

Comment 4

[Patrick Brosset <:pbro>]

Also, I have no ideas why reviewboard considers part 3 as discarded ... What happened was I pushed to reviewboard once, realized I missed something, so I discarded the whole review (not just one part, I think), and then pushed again with the changes.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://reviewboard.mozilla.org/r/5585/#review4587

Ship It!

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://reviewboard.mozilla.org/r/5587/#review4589

Ship It!

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://reviewboard.mozilla.org/r/5589/#review4591

Ship It!

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8579286 [details]
MozReview Request: bz://1120343/pbrosset

https://reviewboard.mozilla.org/r/5583/#review4593

Ship It!

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://reviewboard.mozilla.org/r/5585/#review4595

Comment 10

[Patrick Brosset <:pbro>]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=217c2d5e3aa3

Comment 11

[Patrick Brosset <:pbro>]

remote:   https://hg.mozilla.org/integration/fx-team/rev/39871e383356
remote:   https://hg.mozilla.org/integration/fx-team/rev/220cb8916ff4
remote:   https://hg.mozilla.org/integration/fx-team/rev/8eee838b8c46

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/39871e383356
https://hg.mozilla.org/mozilla-central/rev/220cb8916ff4
https://hg.mozilla.org/mozilla-central/rev/8eee838b8c46

Comment 14

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: Bug 1120343 - 1 - Allow setting animations' currentTime by clicking/dragging the timeline

Comment 15

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: Bug 1120343 - 2 - Add rewind and fast-forward buttons to animation player widgets

Comment 16

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: Bug 1120343 - 3 - Tests for the current time control in the animation panel