Closed Bug 1120357 Opened 7 years ago Closed 7 years ago

[Stingray] Apply visual to app install and cancel dialog

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dwi2, Assigned: selee)

References

Details

(Whiteboard: [ft:conndevices][Stingray-Branch])

Attachments

(1 file, 1 obsolete file)

We should apply visual "4.7 Building blocks - Dialog - Prompt Two Btns" to app install and cancel dialog.
And also confirm dialog
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Whiteboard: [ft:conndevices] → [ft:conndevices][ETA:1/23]
Instead of visual, focus issue for pop-up windows need to be addressed. Tzu-lin, would you like to fix focus issue in this bug or file another bug? If file another bug, please make that one as high-priority and remove this from high-priority list. Thanks.
Flags: needinfo?(tzhuang)
Focus issues of pop-up windows and dialog in system app should be fixed in bug 1115289 (which is already tracking by focus meta bug). I prefer only apply visual here.
Flags: needinfo?(tzhuang)
Whiteboard: [ft:conndevices][ETA:1/23] → [ft:conndevices]
Component: Gaia::System → Gaia::TV
Here is WIP: https://github.com/dwi2/gaia/tree/bug1120357

Because I am working on other bugs, this might not be completed before 1/23. Remove ETA.
Attached file PR for master
Hi John,

The patch is based on Tzu-Lin's WIP at comment 4, and I finish it.
Could you help to review my patch?
Thank you.
Assignee: tzhuang → selee
Attachment #8558383 - Flags: review?(im)
Attachment #8558376 - Attachment is obsolete: true
Hi John,

I've updated my patch. Please help to review it again.
Thank you!
Comment on attachment 8558383 [details] [review]
PR for master

Looks pretty good. But we need the support of `esc` key. BTW, please check with visual if we need to add transition to background-color and color while button is pressed or focused.
Attachment #8558383 - Flags: review?(im)
Comment on attachment 8558383 [details] [review]
PR for master

Hi John,

I've updated my patch.
Please help to review it again. Thank you.
Attachment #8558383 - Flags: review?(im)
Comment on attachment 8558383 [details] [review]
PR for master

looks good to me.
Attachment #8558383 - Flags: review?(im) → review+
Whiteboard: [ft:conndevices] → [ft:conndevices][Stingray-Branch]
Daisuke,

We will land this patch to our master. It gives us a whole new install/uninstall dialog. We would suggest you to pick this patch. But please also test it in your side. Thanks.
Flags: needinfo?(938.daisuke)
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
(In reply to John Hu [:johnhu][:johu][:醬糊小弟] from comment #11)
> Daisuke,
> 
> We will land this patch to our master. It gives us a whole new
> install/uninstall dialog. We would suggest you to pick this patch. But
> please also test it in your side. Thanks.

Hi John

Sorry for late reply.
Currently we have no app install dialog(our stingray spec for app install is not fixed)
and so keep it my mind and introduce when this necessary.

Thanks,
Daisuke
Flags: needinfo?(938.daisuke)
You need to log in before you can comment on or make changes to this bug.