Closed Bug 1120360 Opened 7 years ago Closed 6 years ago

libicu ignores --disable-debug-symbols & --disable-debug

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mliska, Unassigned)

References

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.104 Safari/537.36

Steps to reproduce:

My mozconfig contains two options mentioned in the subject, but icu is built with -g option:

intl/icu/target> CFLAGS=-fPIC -Wall -Wdeclaration-after-statement -Wempty-body -Wpointer-to-int-cast -Wsign-compare -Wtype-limits -Wno-unused -Wcast-align -flto=9 -O2 -D_GLIBCXX_USE_CXX11_ABI=0 -std=gnu99 -fgnu89-inline -fno-strict-aliasing -fno-math-errno -pthread -pipe-g -UDEBUG -DNDEBUG -O2 -DU_STATIC_IMPLEMENTATION -fvisibility=hidden -std=c99 -Wall -pedantic -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -Wno-sign-compare -Wno-unused $(THREADSCFLAGS) 
intl/icu/target> CXXFLAGS=-fPIC -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -flto=9 -O2 -D_GLIBCXX_USE_CXX11_ABI=0 -fno-exceptions -fno-strict-aliasing -frtti -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -g -UDEBUG -DNDEBUG -O2 -DU_STATIC_IMPLEMENTATION -fvisibility=hidden -W -Wall -pedantic -Wpointer-arith -Wwrite-strings -Wno-long-long -Wno-unused -Wno-unused-parameter $(THREADSCXXFLAGS) 
c++ -fPIC -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -flto=9 -O2 -D_GLIBCXX_USE_CXX11_ABI=0 -fno-exceptions -fno-strict-aliasing -frtti -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -g -UDEBUG -DNDEBUG -O2 -DU_STATIC_IMPLEMENTATION -fvisibility=hidden -W -Wall -pedantic -Wpointer-arith -Wwrite-strings -Wno-long-long -Wno-unused -Wno-unused-parameter   -lpthread -flto=9 -O2 -D_GLIBCXX_USE_CXX11_ABI=0 -Wl,-z,noexecstack -Wl,-z,text -Wl,--build-id -Wl,--gc-sections  -o ../../bin/makeconv makeconv.o ucnvstat.o genmbcs.o gencnvex.o -L../../lib -licutu -L../../lib -licui18n -L../../lib -licuuc -L../../stubdata -licudata -lpthread -ldl -lm  
c++ -fPIC -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -flto=9 -O2 -D_GLIBCXX_USE_CXX11_ABI=0 -fno-exceptions -fno-strict-aliasing -frtti -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -g -UDEBUG -DNDEBUG -O2 -DU_STATIC_IMPLEMENTATION -fvisibility=hidden -W -Wall -pedantic -Wpointer-arith -Wwrite-strings -Wno-long-long -Wno-unused -Wno-unused-parameter   -lpthread -flto=9 -O2 -D_GLIBCXX_USE_CXX11_ABI=0 -Wl,-z,noexecstack -Wl,-z,text -Wl,--build-id -Wl,--gc-sections  -o ../../bin/genrb errmsg.o genrb.o parse.o read.o reslist.o ustr.o rbutil.o wrtjava.o rle.o wrtxml.o prscmnts.o -L../../lib -licutu -L../../lib -licui18n -L../../lib -licuuc -L../../stubdata -licudata -lpthread -ldl -lm  
c++ -fPIC -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -flto=9 -O2 -D_GLIBCXX_USE_CXX11_ABI=0 -fno-exceptions -fno-strict-aliasing -frtti -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -g -UDEBUG -DNDEBUG -O2 -DU_STATIC_IMPLEMENTATION -fvisibility=hidden -W -Wall -pedantic -Wpointer-arith -Wwrite-strings -Wno-long-long -Wno-unused -Wno-unused-parameter   -lpthread -flto=9 -O2 -D_GLIBCXX_USE_CXX11_ABI=0 -Wl,-z,noexecstack -Wl,-z,text -Wl,--build-id -Wl,--gc-sections  -o ../../bin/genbrk genbrk.o -L../../lib -licutu -L../../lib -licui18n -L../../lib -licuuc -L../../stubdata -licudata -lpthread -ldl -lm  
...

.mozconfig:
OPT="-O2"

mk_add_options MOZ_MAKE_FLAGS="-j9"
ac_add_options --enable-application=browser
ac_add_options --enable-optimize=$OPT
# ac_add_options --disable-webm
ac_add_options --disable-dash
ac_add_options --disable-tests
ac_add_options --disable-debug
ac_add_options --disable-debug-symbols

# valgrind purpose
ac_add_options --disable-jemalloc
ac_add_options --disable-valgrind

# ac_add_options --disable-ogg
# ac_add_options --with-system-libvpx
# ac_add_options --disable-necko-wifi
ac_add_options --disable-elf-hack

ac_add_options --disable-gstreamer

MYFLAGS="-flto=9 ${OPT} -D_GLIBCXX_USE_CXX11_ABI=0"
export CFLAGS="$MYFLAGS"
export CXXFLAGS="$MYFLAGS"
export LDFLAGS="$MYFLAGS"

Thanks,
Martin
Component: Untriaged → JavaScript: Internationalization API
Product: Firefox → Core
This will be fixed by bug 1239083.
Component: JavaScript: Internationalization API → Build Config
Depends on: 1239083
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.