"media-fail" indicates the wrong thing on desktop/standalone for direct calls

RESOLVED WONTFIX

Status

P4
normal
Rank:
48
RESOLVED WONTFIX
4 years ago
3 years ago

People

(Reporter: standard8, Unassigned)

Tracking

unspecified
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [errors])

User Story

Notes for devs:

- gUM can only really fail for incoming calls; for outgoing/standalone we shouldn't be activating the call until after having got gUM.

- ICE failures. Currently the only way to get this seems to be to listen to the sdk OT.exception for "Unable to publish" code 1500 (one of the error codes listed in the sdk).
(Reporter)

Description

4 years ago
On Desktop, we're currently only sending media-fail as a termination reason on the websocket when the call is hungup, whilst media connection is still taking place.

We should be sending it when:

- gUM fails
- ICE fails

I'm not sure how we detect ICE at the moment (via the sdk), so we may need to split that to a separate bug.
(Reporter)

Comment 1

4 years ago
We should address this soon as it affects metrics
Severity: enhancement → normal
backlog: --- → Fx38+
Priority: -- → P2
IMO we should prioritize this early in Fx38 and strongly consider uplifting (depending on the risk of the patch).

Shell -- Can you put this on the trello board?
Flags: needinfo?(sescalante)
(Reporter)

Updated

4 years ago
User Story: (updated)

Comment 3

4 years ago
added to trello
Flags: needinfo?(sescalante)
(Reporter)

Updated

4 years ago
Priority: P2 → P1

Comment 4

4 years ago
metrics are important - but rooms use is going up - so rooms use metrics are higher priority than direct calling.
Priority: P1 → P4
(Reporter)

Comment 5

4 years ago
(In reply to sescalante from comment #4)
> metrics are important - but rooms use is going up - so rooms use metrics are
> higher priority than direct calling.

Whilst that's true, I think there's information in direct calls that is going to feed into if rooms are having problems or not - we don't get the same visibility with rooms.

I'd suggest this should be a P2 or P3.
As part of fixing this bug, the media-fail doc at <https://docs.services.mozilla.com/loop/apis.html#termination-reasons> should be updated.

Updated

4 years ago
backlog: Fx38+ → backlog+
Rank: 48
Flags: firefox-backlog+
Whiteboard: [errors]
(Reporter)

Comment 7

3 years ago
We are currently reworking the Loop "user journey" (bug 1209713) and as part of this direct calls and contacts are being removed. Therefore closing direct call related bugs as wontfix.

Tracking id: directcallclosing
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.