Closed Bug 1120381 Opened 9 years ago Closed 9 years ago

[Stingray][Home] Pressing up shouldn't navigate from second row of grid view to top scrollable list

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rexboy, Assigned: rexboy)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

Under some conditions, it is possible to navigate from second row (or later) to topmost scrollable list.
STR:
1.Navigate to button at center of 3rd row of grid view
2.Press "UP"
3.Press "UP"

Expected:
Focus is now on center of 1st row

Actual:
Focus is now on topmost scrollable list.
Assignee: nobody → rexboy
Attached file Patch
I slightly changed the behavior, such that it locates focused button to vertical middle of grid view. This way buttons one row above would always slightly be on bottom of the scroll list (by our layout), thus avoid the problem above.

Tzu-lin would you help review this bug?
Attachment #8547513 - Flags: review?(tzhuang)
Comment on attachment 8547513 [details] [review]
Patch

I left a comment on PR. It looks good to me overall. Thanks
Attachment #8547513 - Flags: review?(tzhuang) → review+
Whiteboard: [ft:conndevices]
https://github.com/mozilla-b2g/gaia/commit/3b76e0ac46aea1f99338447b082b981433e51d52
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.