Text is bigger than Thunderbird download button in product page for some locales

RESOLVED FIXED in 2015Q1

Status

support.mozilla.org
Knowledge Base Software
P3
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: pollti, Assigned: pollti, Mentored)

Tracking

unspecified
2015Q1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: u=user c=wiki p=0 s=2015.5, URL)

Attachments

(1 attachment)

PR1
44 bytes, text/x-github-pull-request
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Original bug: Bug #1117204

There's a little problem with the locales de https://support.mozilla.org/de/products/thunderbird), fr and it:
The localized string "Free Download" is too long for the button.

Can we maybe choose a smaller font or move up the whole text? (I think making the button bigger would make it too big.)
Another option: we can change the padding on the button to make locales that wrap to two lines still look ok.

I'm putting this in the next sprint to work on. If someone else would like to tackle it before then, go for it!
Priority: -- → P3
Whiteboard: p=1 u=user c=kb s=2015.2 [good first bug] [mentor=mythmon]
We aren't going to do this this sprint.
Whiteboard: p=1 u=user c=kb s=2015.2 [good first bug] [mentor=mythmon] → p=1 u=user c=kb s= [good first bug] [mentor=mythmon]
Changing this to use the new(ish) mentor field instead of whiteboard data.
Mentor: mcooper@mozilla.com
Whiteboard: p=1 u=user c=kb s= [good first bug] [mentor=mythmon] → p=1 u=user c=kb s= [good first bug]
(Assignee)

Comment 4

3 years ago
Created attachment 8576113 [details] [review]
PR1
Attachment #8576113 - Flags: review?(mcooper)
(Assignee)

Updated

3 years ago
Assignee: nobody → pollti
Status: NEW → ASSIGNED
Comment on attachment 8576113 [details] [review]
PR1

We don't do bugzilla reviews on SUMO.

PR: https://github.com/mozilla/kitsune/pull/2409

This was merged in https://github.com/mozilla/kitsune/commit/deff8beed787e415dfabeb8e4793e92c0dab0e20

This bug will be closed when we deploy this change.
Attachment #8576113 - Flags: review?(mcooper)
Deployed to prod.

Thanks Tim!
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: p=1 u=user c=kb s= [good first bug] → u=user c=wiki p=0 s=2015.5
Target Milestone: --- → 2015Q1
You need to log in before you can comment on or make changes to this bug.