Closed
Bug 1120513
Opened 9 years ago
Closed 9 years ago
[Task Manager] Update background to dark grey
Categories
(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)
Tracking
(b2g-v2.2 verified, b2g-master verified)
VERIFIED
FIXED
2.2 S6 (20feb)
People
(Reporter: epang, Assigned: sfoster)
References
Details
(Whiteboard: [systemsfe])
Attachments
(3 files)
46 bytes,
text/x-github-pull-request
|
etienne
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
66.50 KB,
image/png
|
epang
:
ui-review+
|
Details |
69.18 KB,
image/png
|
Details |
Since we are not able to use the background planned for task manager can we update from black to dark gray #333333 Thanks!
Reporter | ||
Comment 1•9 years ago
|
||
sorry wrong hex, please update to #5f5f5f Thanks!
Reporter | ||
Comment 2•9 years ago
|
||
(In reply to Eric Pang [:epang] from comment #1) > sorry wrong hex, please update to #5f5f5f > Thanks! Sorry Sam, I made a mistake on the search app spec. We should use #4d4d4d so the background is consistent. Please ignore the other hex values above. Thanks!
Flags: needinfo?(sfoster)
Assignee | ||
Comment 4•9 years ago
|
||
Just swaps out the background color for the (apps-mode) task manager. Empty state and filtered/tab view is unchanged.
Attachment #8553330 -
Flags: review?(etienne)
Comment 5•9 years ago
|
||
Comment on attachment 8553330 [details] [review] GH Pull Request found a nit :)
Attachment #8553330 -
Flags: review?(etienne) → review+
Reporter | ||
Comment 6•9 years ago
|
||
(In reply to Sam Foster [:sfoster] from comment #4) > Created attachment 8553330 [details] [review] > GH Pull Request > > Just swaps out the background color for the (apps-mode) task manager. Empty > state and filtered/tab view is unchanged. Hey Sam, Hold off landing this, there's a big change we're going to update the RB search background to #333333. So we might have to update this too :). Thanks!
Reporter | ||
Comment 7•9 years ago
|
||
Marked dependent on bug 1125810. This bug will update the background of the search app background to #333333. The background of the task manager should match what we use in the RB search.
Depends on: 1125810
Assignee | ||
Comment 8•9 years ago
|
||
Screenshot of task manager with fully opaque #333 background color, and 85% opaque #333 for empty state
Attachment #8560620 -
Flags: ui-review?(epang)
Reporter | ||
Comment 9•9 years ago
|
||
Comment on attachment 8560620 [details]
taskmanager-bg.png
Thanks Sam, looks good to me!
Attachment #8560620 -
Flags: ui-review?(epang) → ui-review+
Assignee | ||
Comment 10•9 years ago
|
||
Merged to master: https://github.com/mozilla-b2g/gaia/commit/c568fb4e6732788c835c236147d34a6b02ca9bb7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8553330 [details] [review] GH Pull Request [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Task Manager [User impact] if declined: Inconsistency with colors used in Rocketbar/Search [Testing completed]: On device, Gaia-Try [Risk to taking this patch] (and alternatives if risky): Zero? CSS only patch that tweaks some background-colors [String changes made]: None
Attachment #8553330 -
Flags: approval-gaia-v2.2?
Updated•9 years ago
|
Attachment #8553330 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 12•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/a067732a071600574091abf1a5baed22918bd8a4
Comment 14•9 years ago
|
||
This bug has been verified as "pass" on latest build of Flame 2.2 & master,Nexus5 2.2 & master STR. Prerequisite:No app running in background. 1.Invoke Taskmanager then check background color. 2.Open an app. 3.Invoke Taskmanager then check background color. Actually result:Background color is gray. Reproduce rate: 0/10 See attachment: verify.png Device: Flame 2.2 (pass): Build ID 20150701162502 Gaia Revision bd386f346eb1591fddbc84bf034b22700e7e2a58 Gaia Date 2015-06-30 15:53:15 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f16c1125b9d6 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150701.195343 Firmware Date Wed Jul 1 19:53:55 EDT 2015 Bootloader L1TC000118D0 Device: Flame_master (pass): Build ID 20150701160205 Gaia Revision 858764a56982eb558259ccc689bbee855f090085 Gaia Date 2015-07-01 16:59:48 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/c36f68439496 Gecko Version 42.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150701.193443 Firmware Date Wed Jul 1 19:34:55 EDT 2015 Bootloader L1TC000118D0 Device: Nexus 5_2.2 (pass): Build ID 20150701162502 Gaia Revision bd386f346eb1591fddbc84bf034b22700e7e2a58 Gaia Date 2015-06-30 15:53:15 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f16c1125b9d6 Gecko Version 37.0 Device Name hammerhead Firmware(Release) 5.1 Firmware(Incremental) eng.cltbld.20150701.195806 Firmware Date Wed Jul 1 19:58:26 EDT 2015 Bootloader HHZ12f Device: Nexus 5_master (pass): Build ID 20150701160205 Gaia Revision 858764a56982eb558259ccc689bbee855f090085 Gaia Date 2015-07-01 16:59:48 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/c36f68439496 Gecko Version 42.0a1 Device Name hammerhead Firmware(Release) 5.1 Firmware(Incremental) eng.cltbld.20150701.193431 Firmware Date Wed Jul 1 19:34:50 EDT 2015 Bootloader HHZ12f
Updated•9 years ago
|
Status: RESOLVED → VERIFIED
QA Whiteboard: [MGSEI-Triage+]
You need to log in
before you can comment on or make changes to this bug.
Description
•