Closed
Bug 1120589
Opened 9 years ago
Closed 9 years ago
Ship-it: partial pre-filling not working
Categories
(Release Engineering :: Applications: Shipit, defect)
Release Engineering
Applications: Shipit
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(1 file)
|
4.18 KB,
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
fails with: "ReferenceError: partialElement is not defined"
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → sledru
|
||
Comment 1•9 years ago
|
||
Same for 35.0 and 35.0.1.
Summary: Ship-it: Selecting a beta 1 fails with an error → Ship-it: partial pre-filling not working
|
|
Assignee | |
Comment 2•9 years ago
|
||
In the bug 1112117, I had to move populatePartial as first level function. This function was using partialElement from the upper scope and I forgot to update the code to move it as an argument :/
Attachment #8548014 -
Flags: review?(bhearsum)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8548014 [details] [diff] [review] 0001-Bug-1120589-Fix-the-partial-pre-filling.patch Review of attachment 8548014 [details] [diff] [review]: ----------------------------------------------------------------- Oops!
Attachment #8548014 -
Flags: review?(bhearsum) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Indeed, oops :p http://git.mozilla.org/?p=build/release-kickoff.git;a=commitdiff;h=982514fb7e92990f8b2f206476262c1857447d7b
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Component: Release Automation → Ship It
Resolution: --- → FIXED
|
|
||
Comment 5•9 years ago
|
||
Mass component change for ship it bugs.
|
||
Updated•2 years ago
|
Component: Applications: ShipIt (backend) → Applications: ShipIt
You need to log in
before you can comment on or make changes to this bug.
Description
•