Closed
Bug 1120728
Opened 11 years ago
Closed 9 years ago
remove nsIUrlClassifierDBServiceWorker
Categories
(Toolkit :: Safe Browsing, defect, P5)
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: mmc, Assigned: tnguyen)
References
Details
Attachments
(1 file, 1 obsolete file)
Once bug 1120499 is complete, there should be no more references to this interface, nsUrlClassifierDBService works on concrete classes UrlClassifierDBServiceWorker{Proxy,} only.
|
||
Updated•10 years ago
|
Component: DOM: Security → Safe Browsing
Product: Core → Toolkit
|
||
Updated•9 years ago
|
Priority: -- → P5
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → tnguyen
|
|
Assignee | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/66290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66290/
Attachment #8773591 -
Flags: review?(francois)
Attachment #8773592 -
Flags: review?(francois)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/66290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66290/
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8773591 [details]
Bug 1120728 - remove nsIUrlClassifierDBServiceWorker.
Seems mozreview posted a duplicated message. Removed this
Attachment #8773591 -
Attachment is obsolete: true
Attachment #8773591 -
Flags: review?(francois)
|
|
||
Updated•9 years ago
|
Attachment #8773591 -
Attachment is obsolete: false
Attachment #8773591 -
Flags: review?(gpascutto)
Attachment #8773591 -
Flags: review?(francois)
|
|
||
Updated•9 years ago
|
Attachment #8773591 -
Flags: review?(francois) → review+
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8773591 [details]
Bug 1120728 - remove nsIUrlClassifierDBServiceWorker.
https://reviewboard.mozilla.org/r/66290/#review65176
Looks good to me.
gcp do you have any concerns with this?
|
|
||
Updated•9 years ago
|
Attachment #8773592 -
Attachment is obsolete: true
Attachment #8773592 -
Flags: review?(francois)
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 6•9 years ago
|
||
|
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8773591 [details]
Bug 1120728 - remove nsIUrlClassifierDBServiceWorker.
https://reviewboard.mozilla.org/r/66290/#review66070
Attachment #8773591 -
Flags: review?(gpascutto) → review+
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 9•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 10•9 years ago
|
||
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/316a84b6888a
remove nsIUrlClassifierDBServiceWorker. r=francois,gcp
Keywords: checkin-needed
|
||
Comment 11•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•