1120744 - Since bug 1110552, the unclassified count in the tab title sometimes gets out of sync

Status: RESOLVED WORKSFORME

(Tree Management :: Treeherder, defect, P2)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I've noticed a couple times today after the production pushes that the count of unclassified failures shown in the tab title seems to get out of sync with reality.

I'll look up in the tab title and see "[5]" so I use one of the keyboard shortcuts to select the next/previous unclassified failure, but nothing happens. I scroll up and down the page and don't see anything shown in the "only unclassified" mode.

If I refresh the page, the count in the tab title goes back to "[0]", which matches with reality.


Things to note:
Since the push happened recently, I guess it's possible that some resource is still using a cached version of itself from before the push. I'm pretty sure I've hard refreshed each of my treeherder tabs at this point, though, so seems unlikely.

I haven't looked at the yellow "x unclassified" button in the treeherder header to see if it matches reality or the messed up count in the tab title.

It's possible this is related to putting stuff into the Filter box, but I don't believe any of the instances of this I've noticed have happened while anything is currently in the Filter box.

This probably isn't a huge issue (might not be any issue if it's related to cached older versions of files from before the prod push), so this should be a relatively low priority until/unless it keeps happening for me and anyone else.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

I saw this today too but hadn't put two and two together. Thought I'd just done something silly or something.

Comment 2

[Ed Morley [:emorley]]

Today's prod push only included the OS X 10.10 changes to the UI. 
This sounds much more like a regression from bug 1110552, which was in production on thurs.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

So I'm currently seeing this on my Aurora tab. Tab title says "[10]" but there's no unstarred failures on the page.

The URL I'm on is https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified but the mismatch happens if I toggle off all of the filters by hitting 'u'.

The yellow "X unclassified" in the header matches with the tab title, not with reality.

I'll let it sit here untouched for a bit to see if it corrects itself eventually.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

So I left the Aurora tab open and unrefreshed until a new failure came in. Where it originally said [10] but there were zero unstarred failures actually shown, it now shows [11] with one unstarred failure shown.

Classifying that one failure, the tab title goes back down to [10], but there are no 0 actually unstarred failures.

Comment 5

[Cameron Dawson [:camd]]

that fix may have broken something here, yeah.  Sounds like the likeliest culprit.  I'll see if I can fix it, or back out the other change.

Comment 6

[Cameron Dawson [:camd]]

also: opinions on whether this is a p1 or not?  I think these numbers are pretty important to workflow, but hard to gauge from my end.

Comment 7

[Ed Morley [:emorley]]

Is this still occurring after the refactor/UI changes?

Comment 8

[Cameron Dawson [:camd]]

Un-assigning from myself.  I'm not going to get to this soon.

Comment 9

[Ed Morley [:emorley]]

(In reply to Ed Morley [:emorley] from comment #7)
> Is this still occurring after the refactor/UI changes?

Comment 10

[Ed Morley [:emorley]]

Cheers :-)