1120772 - NSPR's definition of snprintf breaks build when MSVC 2015 is used

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

MSVC 2015 finally added snprintf. MSVC 2015's stdio.h contains this:

#ifdef vsnprintf
    #error Macro definition of vsnprintf conflicts with Standard Library function declaration
#endif
#ifdef snprintf
    #error Macro definition of snprintf conflicts with Standard Library function declaration
#endif

This means we must be careful to never define snprintf or vsnprintf as macros when building with MSVC 2015.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: nspr-snprintf.patch

r=ted in bug 1119776.

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

http://hg.mozilla.org/projects/nspr/rev/e27c8f0bdd5d

Also tagged this NSPR_4_10_8_BETA3 so that I can land it in mozilla-inbound:

http://hg.mozilla.org/projects/nspr/rev/ab846cd2b379