[BT API2] A compile error occurred in BluetoothRilListener.o

RESOLVED FIXED

Status

Firefox OS
Bluetooth
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jaliu, Assigned: jaliu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
bluetooth2/BluetoothRilListener use nsITelephonyCallInfo since Bug 1115603 landed, whereas it didn't include header file.

It raises a compile error with BT API2 build flag.
> BluetoothRilListener.o
> ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp: In member function 'nsresult mozilla::dom::bluetooth::TelephonyListener::HandleCallInfo(nsITelephonyCallInfo*, bool)':
> ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:205:8: error: invalid use of incomplete type 'class nsITelephonyCallInfo'
> In file included from ../../../gecko/dom/bluetooth2/BluetoothRilListener.h:16:0,
>                  from ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:7:
> ../../dist/include/nsITelephonyService.h:19:7: error: forward declaration of 'class nsITelephonyCallInfo'
> ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:206:8: error: invalid use of incomplete type 'class nsITelephonyCallInfo'
> In file included from ../../../gecko/dom/bluetooth2/BluetoothRilListener.h:16:0,
>                  from ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:7:
> ../../dist/include/nsITelephonyService.h:19:7: error: forward declaration of 'class nsITelephonyCallInfo'
> ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:207:8: error: invalid use of incomplete type 'class nsITelephonyCallInfo'
> In file included from ../../../gecko/dom/bluetooth2/BluetoothRilListener.h:16:0,
>                  from ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:7:
> ../../dist/include/nsITelephonyService.h:19:7: error: forward declaration of 'class nsITelephonyCallInfo'
> ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:208:8: error: invalid use of incomplete type 'class nsITelephonyCallInfo'
> In file included from ../../../gecko/dom/bluetooth2/BluetoothRilListener.h:16:0,
>                  from ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:7:
> ../../dist/include/nsITelephonyService.h:19:7: error: forward declaration of 'class nsITelephonyCallInfo'
> ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:209:8: error: invalid use of incomplete type 'class nsITelephonyCallInfo'
> In file included from ../../../gecko/dom/bluetooth2/BluetoothRilListener.h:16:0,
>                  from ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:7:
> ../../dist/include/nsITelephonyService.h:19:7: error: forward declaration of 'class nsITelephonyCallInfo'
(Assignee)

Updated

3 years ago
Assignee: nobody → jaliu
(Assignee)

Comment 1

3 years ago
Created attachment 8547927 [details] [diff] [review]
Include a header file for nsITelephonyCallInfo in bluetooth2/BluetoothRilListener.h (v1)
Attachment #8547927 - Flags: review?(btian)

Comment 2

3 years ago
Comment on attachment 8547927 [details] [diff] [review]
Include a header file for nsITelephonyCallInfo in bluetooth2/BluetoothRilListener.h (v1)

Review of attachment 8547927 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. I should've caught it. Thank!
Attachment #8547927 - Flags: review?(btian) → review+
(Assignee)

Comment 4

3 years ago
(In reply to Ben Tian [:btian] from comment #2)
> Comment on attachment 8547927 [details] [diff] [review]
> Include a header file for nsITelephonyCallInfo in
> bluetooth2/BluetoothRilListener.h (v1)
> 
> Review of attachment 8547927 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> LGTM. I should've caught it. Thank!

Thank you for reviewing the patch. :)
https://hg.mozilla.org/mozilla-central/rev/60558300fd6a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.