1120774 - [BT API2] A compile error occurred in BluetoothRilListener.o

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Jamin Liu [:jaliu][:Jamin]]

bluetooth2/BluetoothRilListener use nsITelephonyCallInfo since Bug 1115603 landed, whereas it didn't include header file.

It raises a compile error with BT API2 build flag.
> BluetoothRilListener.o
> ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp: In member function 'nsresult mozilla::dom::bluetooth::TelephonyListener::HandleCallInfo(nsITelephonyCallInfo*, bool)':
> ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:205:8: error: invalid use of incomplete type 'class nsITelephonyCallInfo'
> In file included from ../../../gecko/dom/bluetooth2/BluetoothRilListener.h:16:0,
>                  from ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:7:
> ../../dist/include/nsITelephonyService.h:19:7: error: forward declaration of 'class nsITelephonyCallInfo'
> ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:206:8: error: invalid use of incomplete type 'class nsITelephonyCallInfo'
> In file included from ../../../gecko/dom/bluetooth2/BluetoothRilListener.h:16:0,
>                  from ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:7:
> ../../dist/include/nsITelephonyService.h:19:7: error: forward declaration of 'class nsITelephonyCallInfo'
> ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:207:8: error: invalid use of incomplete type 'class nsITelephonyCallInfo'
> In file included from ../../../gecko/dom/bluetooth2/BluetoothRilListener.h:16:0,
>                  from ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:7:
> ../../dist/include/nsITelephonyService.h:19:7: error: forward declaration of 'class nsITelephonyCallInfo'
> ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:208:8: error: invalid use of incomplete type 'class nsITelephonyCallInfo'
> In file included from ../../../gecko/dom/bluetooth2/BluetoothRilListener.h:16:0,
>                  from ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:7:
> ../../dist/include/nsITelephonyService.h:19:7: error: forward declaration of 'class nsITelephonyCallInfo'
> ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:209:8: error: invalid use of incomplete type 'class nsITelephonyCallInfo'
> In file included from ../../../gecko/dom/bluetooth2/BluetoothRilListener.h:16:0,
>                  from ../../../gecko/dom/bluetooth2/BluetoothRilListener.cpp:7:
> ../../dist/include/nsITelephonyService.h:19:7: error: forward declaration of 'class nsITelephonyCallInfo'

Comment 1

[Jamin Liu [:jaliu][:Jamin]]

Attachment: Include a header file for nsITelephonyCallInfo in bluetooth2/BluetoothRilListener.h (v1)

Comment 2

[Ben Tian (inactive)]

Comment on attachment 8547927 [details] [diff] [review]
Include a header file for nsITelephonyCallInfo in bluetooth2/BluetoothRilListener.h (v1)

Review of attachment 8547927 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. I should've caught it. Thank!

Comment 3

[Jamin Liu [:jaliu][:Jamin]]

https://hg.mozilla.org/integration/b2g-inbound/rev/60558300fd6a

Comment 4

[Jamin Liu [:jaliu][:Jamin]]

(In reply to Ben Tian [:btian] from comment #2)
> Comment on attachment 8547927 [details] [diff] [review]
> Include a header file for nsITelephonyCallInfo in
> bluetooth2/BluetoothRilListener.h (v1)
> 
> Review of attachment 8547927 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> LGTM. I should've caught it. Thank!

Thank you for reviewing the patch. :)

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/60558300fd6a