1120874 - Telemetry: Record the proportion of saved signons without usernames

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P1)

Comment 1

[Matthew N. [:MattN]]

This isn't necessarily easy if we want to avoid seemingly random MP prompts while telemetry is gathered.

Comment 2

[Chris Karlof [:ckarlof]]

> This isn't necessarily easy if we want to avoid seemingly random MP prompts while telemetry is gathered.

Hilarious punishment for choosing to use MP.

Sync has a mechanism for detecting if MP is enabled, which we could use here, too.

Comment 3

[Matthew N. [:MattN]]

Yeah, detecting whether it's unlocked isn't hard but it's a matter of whether we want to skew the data or not since IIRC double-digit % of our (sync?) users use MP. To avoid most skewing we could cache the value from the last time MP was unlocked.

Comment 4

[Chris Karlof [:ckarlof]]

Last time I measured, MP usage was low single digits:

https://mail.mozilla.org/pipermail/sync-dev/2014-September/000985.html

Comment 5

[Matthew N. [:MattN]]

OK, it seems like it still is around 2% of all users and 5-6% of Sync users. I'm not sure where I heard a number around 10% before. It's still probably enough people that I think if it's easy to avoid the prompt I think we should.

Comment 6

[Justin Dolske [:Dolske]]

We certainly shouldn't trigger a random master password prompt due to telemetry, but I think it's safe to just skip collecting the data if a master password is set. Or, more specifically, skip it when storage.isLoggedIn == false, which is just when you have a master password but haven't entered it yet. I don't think master password users are likely to skew this data significantly.

Comment 7

[:Margaret Leibovic]

Attachment: Create telemetry histogram for whether or not usernames are stored with saved logins

Comment 8

[Matthew N. [:MattN]]

Comment on attachment 8553355 [details] [diff] [review]
Create telemetry histogram for whether or not usernames are stored with saved logins

Review of attachment 8553355 [details] [diff] [review]:
-----------------------------------------------------------------

Note that you'll need to rebase over ally's patch

::: toolkit/components/telemetry/Histograms.json
@@ +7165,5 @@
>    },
> +  "PWMGR_USERNAME_PRESENT": {
> +    "expires_in_version": "never",
> +    "kind": "boolean",
> +    "description": "A login saved with a username (as opposed to no username)"

Nit: Since we're recording both true and false now, how about: "Whether a saved login has a username".

Comment 9

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/fb9f35edd87a

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fb9f35edd87a

Comment 11

[Matthew N. [:MattN]]

Comment on attachment 8553355 [details] [diff] [review]
Create telemetry histogram for whether or not usernames are stored with saved logins

Approval Request Comment
[Feature/regressing bug #]: Improvements to password manager in 2015 - Bug 1121127
[User impact if declined]: Possibly less ideal decisions based on lack of data.
[Describe test coverage new/current, TreeHerder]: No tests for the telemetry since it's outside the normal code flow so shouldn't break other aspects of password manager if an exception occurs. No problems have been reported on Nightly and data looks good there.
[Risks and why]: Low risk since it's new code only run during the telemetry gathering phase.
[String/UUID change made/needed]: None

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8553355 [details] [diff] [review]
Create telemetry histogram for whether or not usernames are stored with saved logins

I'm not sure about the value of uplifting this patch to Beta at this point in the cycle. (I'll leave it to Sylvestre to make the call on that.) Happy to take this on Aurora.

Aurora+

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/29b870324ecb

Comment 14

[Chris Karlof [:ckarlof]]

Does anyone else find it curious that the shape of this probe is very similar to PWMGR_SAVING_ENABLED?

https://telemetry.mozilla.org/#filter=nightly%2F38%2FPWMGR_SAVING_ENABLED%2Fsaved_session%2FFirefox&aggregates=multiselect-all!Submissions&evoOver=Builds&locked=true&sanitize=true&renderhistogram=Graph

https://telemetry.mozilla.org/#filter=nightly%2F38%2FPWMGR_USERNAME_PRESENT%2Fsaved_session%2FFirefox&aggregates=multiselect-all!Submissions&evoOver=Builds&locked=true&sanitize=true&renderhistogram=Graph

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8553355 [details] [diff] [review]
Create telemetry histogram for whether or not usernames are stored with saved logins

Too late for beta.