Closed Bug 1120874 Opened 5 years ago Closed 5 years ago

Telemetry: Record the proportion of saved signons without usernames

Categories

(Toolkit :: Password Manager, defect, P1)

defect
Points:
5

Tracking

()

RESOLVED FIXED
mozilla38
Iteration:
38.1 - 26 Jan
Tracking Status
firefox36 --- affected
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: MattN, Assigned: Margaret)

References

(Blocks 1 open bug)

Details

User Story

* In order to measure the impact of fixing bug 1016051 and allowing users to override/edit the saved username value through the UI, it's useful to know the percentage of saved signons that don't have a username associated with them. It's easy to get in this state if a password is first saved on a password reset or other page without the user's username in a field.

This also helps measure the impact of the username portion of bug 1120129 although less so since we may still save some other non-username input if one is present so the presence of a username doesn't necessarily mean it's correct.

Attachments

(1 file)

No description provided.
Flags: firefox-backlog+
User Story: (updated)
See Also: → 1120129
This isn't necessarily easy if we want to avoid seemingly random MP prompts while telemetry is gathered.
Points: --- → 5
Flags: qe-verify-
> This isn't necessarily easy if we want to avoid seemingly random MP prompts while telemetry is gathered.

Hilarious punishment for choosing to use MP.

Sync has a mechanism for detecting if MP is enabled, which we could use here, too.
Yeah, detecting whether it's unlocked isn't hard but it's a matter of whether we want to skew the data or not since IIRC double-digit % of our (sync?) users use MP. To avoid most skewing we could cache the value from the last time MP was unlocked.
Last time I measured, MP usage was low single digits:

https://mail.mozilla.org/pipermail/sync-dev/2014-September/000985.html
OK, it seems like it still is around 2% of all users and 5-6% of Sync users. I'm not sure where I heard a number around 10% before. It's still probably enough people that I think if it's easy to avoid the prompt I think we should.
We certainly shouldn't trigger a random master password prompt due to telemetry, but I think it's safe to just skip collecting the data if a master password is set. Or, more specifically, skip it when storage.isLoggedIn == false, which is just when you have a master password but haven't entered it yet. I don't think master password users are likely to skew this data significantly.
Priority: -- → P1
Assignee: nobody → margaret.leibovic
Comment on attachment 8553355 [details] [diff] [review]
Create telemetry histogram for whether or not usernames are stored with saved logins

Review of attachment 8553355 [details] [diff] [review]:
-----------------------------------------------------------------

Note that you'll need to rebase over ally's patch

::: toolkit/components/telemetry/Histograms.json
@@ +7165,5 @@
>    },
> +  "PWMGR_USERNAME_PRESENT": {
> +    "expires_in_version": "never",
> +    "kind": "boolean",
> +    "description": "A login saved with a username (as opposed to no username)"

Nit: Since we're recording both true and false now, how about: "Whether a saved login has a username".
Attachment #8553355 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/fb9f35edd87a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Iteration: --- → 38.1 - 26 Jan
Comment on attachment 8553355 [details] [diff] [review]
Create telemetry histogram for whether or not usernames are stored with saved logins

Approval Request Comment
[Feature/regressing bug #]: Improvements to password manager in 2015 - Bug 1121127
[User impact if declined]: Possibly less ideal decisions based on lack of data.
[Describe test coverage new/current, TreeHerder]: No tests for the telemetry since it's outside the normal code flow so shouldn't break other aspects of password manager if an exception occurs. No problems have been reported on Nightly and data looks good there.
[Risks and why]: Low risk since it's new code only run during the telemetry gathering phase.
[String/UUID change made/needed]: None
Attachment #8553355 - Flags: approval-mozilla-beta?
Attachment #8553355 - Flags: approval-mozilla-aurora?
Comment on attachment 8553355 [details] [diff] [review]
Create telemetry histogram for whether or not usernames are stored with saved logins

I'm not sure about the value of uplifting this patch to Beta at this point in the cycle. (I'll leave it to Sylvestre to make the call on that.) Happy to take this on Aurora.

Aurora+
Attachment #8553355 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8553355 [details] [diff] [review]
Create telemetry histogram for whether or not usernames are stored with saved logins

Too late for beta.
Attachment #8553355 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
You need to log in before you can comment on or make changes to this bug.