Closed Bug 1120881 Opened 9 years ago Closed 9 years ago

MozNFCTag.canBeMadeReadOnly is incorrect.

Categories

(Firefox OS Graveyard :: NFC, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox36 wontfix, firefox37 wontfix, firefox38 fixed, b2g-v2.2 verified, b2g-master verified)

VERIFIED FIXED
2.2 S4 (23jan)
Tracking Status
firefox36 --- wontfix
firefox37 --- wontfix
firefox38 --- fixed
b2g-v2.2 --- verified
b2g-master --- verified

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file)

In Bug 1115673 I change the naming of tagType but forgot to change it in nsNfc.js.
QA Whiteboard: [COM=NFC]
Attachment #8548117 - Flags: review?(dlee) → review+
https://hg.mozilla.org/mozilla-central/rev/98cbb305fc8f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8548117 [details] [diff] [review]
Patch.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
Bug 1115673

User impact if declined: 
WebAPI (MozNFCTag.canBeMadeReadOnly) cannot return correct value.

Testing completed: 
Yes, with manual test on test app.

Risk to taking this patch (and alternatives if risky): 
No.

String or UUID changes made by this patch:
No.
Attachment #8548117 - Flags: approval-mozilla-b2g37?
Attachment #8548117 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
Verified on
[2.2]
Gaia-Rev        e4f9b5da3751798f9cc5d95f302c30722cc11fca
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4a90da67661e
Build-ID        20150121162503
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150121.201218
FW-Date         Wed Jan 21 20:12:28 EST 2015
Bootloader      L1TC000118D0

[3.0]
Gaia-Rev        917b6c36717fddc6e71ffc1ec249633c8044c93c
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/34e2d2bd7ec4
Build-ID        20150121160202
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150121.192948
FW-Date         Wed Jan 21 19:29:59 EST 2015
Bootloader      L1TC000118D0
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: