Closed Bug 1120924 Opened 5 years ago Closed 5 years ago

TraceLogger: deduplicate emitEpilogue and emitPrologue

Categories

(Core :: JavaScript Engine: JIT, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: h4writer, Assigned: h4writer)

References

Details

Attachments

(1 file)

Blocks: 1119220
Attached patch PatchSplinter Review
Assignee: nobody → hv1989
Attachment #8548172 - Flags: review?(benj)
Comment on attachment 8548172 [details] [diff] [review]
Patch

Review of attachment 8548172 [details] [diff] [review]:
-----------------------------------------------------------------

How about also putting the #ifdef in emitTracelogIonStart/Stop()? They'll get optimized away by the compiler anyways
Attachment #8548172 - Flags: review?(benj) → review+
https://hg.mozilla.org/mozilla-central/rev/d8467e9bbae8
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.