Closed Bug 1120935 Opened 9 years ago Closed 6 years ago

Elasticsearch crash storage should re-format all date fields

Categories

(Socorro :: Backend, task)

Product:
Socorro
Component:
Backend
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: adrian, Unassigned)

References

Details

Date formats are very inconsistent across our fields, and that makes our mapping a bit painful. We would better if we supported only one datetime format, and make sure the processors sends date fields in this format. Using the Super Search Fields list to get the list of date fields, we can solve this problem quite easily.
It is highly possible that bug 1120973 will make this unneeded. Let's wait until it's done before doing anything here.
Depends on: 1120973
I vote for the ISO format: 2015-01-13T15:54:51.561124+00:00 everywhere. Yes, that includes timezone info.
Seems like this is handled already.

https://github.com/mozilla-services/socorro/blob/f90974c282e70ca4bf0e19951fd57b28811d29b8/socorro/external/es/crashstorage.py#L222

That static method converts date time values into a datetime object before saving to Elasticsearch.

That was added in June 2015 after this bug was written:

https://github.com/mozilla-services/socorro/commit/28d0240c77a6221d41c35ff3520697745695e4d6

Pretty sure that covers this. Marking as FIXED now.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.