1120940 - Incorrect keyboard shortcut for "Show all bookmarks" [lv]

Status: RESOLVED FIXED

(Mozilla Localizations :: lv / Latvian, defect)

Description

[Teodor Druta]

http://mxr.mozilla.org/l10n-central/source/lv/browser/chrome/browser/browser.dtd#423

The keyboard shortcut for "bookmarksCmd.commandkey" is set to "g", instead of "b" as it is set on all other locales, making the "Show all bookmarks" keyboard shortcut unusable.

Comment 1

[Raivis Dejus]

Changed the shortcut to "b"

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Raivis, would it be possible for you to backport this to Aurora and even Beta? For beta we had to disable the lv locale for running automated Mozmill tests against it. If that single issue could be fixed down to this branch we can re-enable the locale again.

Comment 3

[Raivis Dejus]

I have committed the fix in aurora, beta and central.
If something still breaks, let me know.

Comment 4

[Francesco Lodolo [:flod]]

(In reply to Raivis Dejus from comment #3)
> I have committed the fix in aurora, beta and central.
> If something still breaks, let me know.

l10n-central and mozilla-aurora were in a merged state before this push, and I need them to be for searchplugin updates since you don't work on l10n-central.

They're now in sync again, make sure you run a "hg pull -u default" in your locale clones before doing more changes
http://hg.mozilla.org/releases/l10n/mozilla-aurora/lv/graph

Why this? If you want to update l10n-central with the latest changes from aurora, that's very simple.

Assume you have two folders
l10n-central (clone of http://hg.mozilla.org/l10n-central/lv)
mozilla-aurora (clone of http://hg.mozilla.org/releases/l10n/mozilla-aurora/lv)

If you want to update l10n-central, you simply pull aurora's changesets in l10n-central, update and push.

cd l10n-central
hg pull -r default ../mozilla-aurora
hg update
hg push

This will keep both repositories in sync without bothering about moving files, merging, etc.

Feel free to reach out to me if this sounds confusing or have doubts.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Raivis Dejus from comment #3)
> I have committed the fix in aurora, beta and central.
> If something still breaks, let me know.

Thanks a lot Raivis! For beta we might still have to wait for the next signoff on this change. So can someone please let us know when this happened? We will re-enable the lv locale for testing then.