Closed
Bug 1120952
Opened 10 years ago
Closed 10 years ago
fix optin/optout metrics
Categories
(Input Graveyard :: Submission, defect, P1)
Input Graveyard
Submission
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
Details
(Whiteboard: u=dev c=feedback p=1 s=input.2015q1)
The generic feedback form can capture remote-troubleshooting data and send it along with the feedback. The code in _handle_feedback_post checks to see if the user opted in and if so, does some work to capture the data and sends a statsd "optin" ping. If the user did not opt in, then it sends a statsd "optout" ping.
However, the code is overly broad. It should only be tracking optin/optout for the "Firefox" product and nothing else. What's going on now is that the Input dashboard shows a lot of optouts, but it shouldn't. It's hard to know what the "norm" should be so that we know when the site is "healthy".
This bug covers fixing that code.
Assignee | ||
Comment 1•10 years ago
|
||
Making this a P1 and grabbing it. I need this to be working correctly soon. Having said that, it's release week so the earliest we can fix this is next week.
Assignee: nobody → willkg
Priority: -- → P1
Assignee | ||
Comment 2•10 years ago
|
||
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•10 years ago
|
||
Landed in master: https://github.com/mozilla/fjord/commit/f75a94244595a00bbb4ee569e27e09afbbda42ff
Pushed this to production just now. Marking as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•10 years ago
|
||
Marking this as 1 point retroactively.
Also, I got the wrong commit. It was this one:
https://github.com/mozilla/fjord/commit/60553bc5ff6f7aa7a58b06a6c7bae8ed4561ee8f
Whiteboard: u=dev c=feedback p= s=input.2015q1 → u=dev c=feedback p=1 s=input.2015q1
Updated•8 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•