Remove NativeObject::lookup workaround for MSVC bug

RESOLVED FIXED in mozilla38

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla38
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8548220 [details] [diff] [review]
Patch

NativeObject::lookup is MOZ_NEVER_INLINE with MSVC to work around a VS 2008/2010 compiler bug, see bug 718541. We require VS 2013 now, there have been a ton of changes to the code and I don't see any crashes with the workaround removed:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c66566248569
Attachment #8548220 - Flags: review?(jwalden+bmo)

Updated

4 years ago
Attachment #8548220 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/d60a0e201e2c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.