1121002 - [Loop] Contact's name is shown below the room name when owner cancels sending the url a contact to share the room

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Loli (:lolimartinezcr)]

Flame
2.0
Gecko-5f9dc54
Gaia-31d6c94
Loop version: master/51a04dd

Pre-requisites:
User A logged in Mobile Loop application.
User A has already created a room but has not invited anyone. The room name is shown in the room list.
User B is a contact saved  with name, phone number and email.

STRs:
1. User A: On Rooms list view, long tap on a room created by user A but not shared with anyone yet
2. Tap on Share room option
3. On Contact list view, select a valid contact (User B: with email and phone number)
4. Select share via phone number (SMS).
5. Once SMS app, tap on 'x' button to close the app (ER1)
5. Check Room list view (ER2)

Expected result:
ER1. The url is not shared with the contact. User A is taken back to Room list view
ER2. Contact's name is not shown below the room name

Actual result:
The url is not shared with the contact. User A is taken back to Room list view.  Contact's name *is shown* below the room name


Also is reproducible
STRs:
1. User A: On Rooms list view,  tap on a room created in ">"
2. One edit the rooom, tap on "Pick contact" button.
3. On Contact list view, select a valid contact (User B: with email and phone number)
4. Select share via phone number (SMS).
5. Once SMS app, tap on 'x' button to close the app 
5. Check Room list view

Comment 1

[Maria Angeles Oteo (:oteo)]

I think that's the correct behavior because the Loop application is not able to know if the e-mail has been sent or not. 

So as soon as the e-mail application is opened and independently if later the e-mail has been sent, kept as a draft or discarded, it hould be updated with the contact shared in the invitees list and in the Room list.

Comment 2

[Maria Angeles Oteo (:oteo)]

(In reply to Maria Angeles Oteo (:oteo) from comment #1)
> I think that's the correct behavior because the Loop application is not able
> to know if the e-mail has been sent or not. 
> 
> So as soon as the e-mail application is opened and independently if later
> the e-mail has been sent, kept as a draft or discarded, it should be updated
> with the contact shared in the invitees list and in the Room list.

Sorry I wanted to say SMS application instead of E-mail application,according with the reported bug.

Anyway both applications should behave in the same way, and as soon as they are opened when selecting a contact to share a room the contact should be updated in the invitees list.

Checking this behavior with Loli, we have realized that E-mail is the one that is not working fine,so Loli, please could you open the corresponding bug for E-mail app. Thanks a lot!!!

I am closing this bug as invalid.

Comment 3

[Loli (:lolimartinezcr)]

(In reply to Maria Angeles Oteo (:oteo) from comment #2)
> (In reply to Maria Angeles Oteo (:oteo) from comment #1)
> > I think that's the correct behavior because the Loop application is not able
> > to know if the e-mail has been sent or not. 
> > 
> > So as soon as the e-mail application is opened and independently if later
> > the e-mail has been sent, kept as a draft or discarded, it should be updated
> > with the contact shared in the invitees list and in the Room list.
> 
> Sorry I wanted to say SMS application instead of E-mail
> application,according with the reported bug.
> 
> Anyway both applications should behave in the same way, and as soon as they
> are opened when selecting a contact to share a room the contact should be
> updated in the invitees list.
> 
> Checking this behavior with Loli, we have realized that E-mail is the one
> that is not working fine,so Loli, please could you open the corresponding
> bug for E-mail app. Thanks a lot!!!
> 
> I am closing this bug as invalid.

New bug about Email created: https://bugzilla.mozilla.org/show_bug.cgi?id=1121452

Comment 4

[Maria Angeles Oteo (:oteo)]

Reopening the bug because this issue happens, but as far as I remember Julien told us that SMS is not going to change its behavior so I suspect that the bug will be solved as Won't fix or invalid

Comment 5

[Julien Wajsberg [:julienw]]

Currently there is no difference but maybe we could use postError instead of postResult when the user closes the activity without sending ? Or postResult with a result ?

Oleg, because you worked on SMS activity a lot, I think you could have a good opinion on this. What do you think?

Comment 6

[Julien Wajsberg [:julienw]]

Also NI Andrew, to know if and how email handles this, because we should do the same thing.

Hey Andrew, do you return a special value or error to the activity caller when the user closes the activity before sending a mail?

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

We postError('cancelled') if the user backs out.  Versus our postResult('complete') if they actually send a message.

Comment 8

[Julien Wajsberg [:julienw]]

Thanks, we should definitely behave the same then.

Comment 10

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 11

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(