FHR data migration: intl.accept_languages

RESOLVED WORKSFORME

Status

Firefox Health Report
Client: Desktop
RESOLVED WORKSFORME
3 years ago
3 years ago

People

(Reporter: Dexter, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
org.mozilla.appInfo.appinfo has the following data:
  isBlocklistEnabled (v2) - is NOT in telemetry
  isTelemetryEnabled (v2) - Is NOT in telemetry, but I don't think it is needed
  vendor - is NOT in telemetry
  name - is in telemetry via [1]
  id - is in telemetry via [1]
  version - is in telemetry via [1]
  appBuildID - is in telemetry via [1]
  platformVersion - is NOT in telemetry
  platformBuildID - is in telemetry via [1]
  os - is in telemetry via [1]
  xpcomabi - is NOT in telemetry
  updateChannel - is in telemetry via [1]
  distributionId - is NOT in telemetry
  distributionVersion - is NOT in telemetry
  hotfixVersion - is NOT in telemetry
  locale - is in telemetry via [1]
  isDefaultBrowser - via [2], BROWSER_IS_USER_DEFAULT histogram

We need to add isBlocklistEnabled, vendor, platformVersion, xpcomabi, distributionId, distributionVersion, hotfixVersion.

[1] - https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/TelemetryPing.jsm#523
[2] - https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/Histograms.json#6378
(Reporter)

Updated

3 years ago
Blocks: 1120356
(Reporter)

Updated

3 years ago
Blocks: 1121013
(Reporter)

Updated

3 years ago
No longer blocks: 1121013
Summary: FHR data migration: org.mozilla.appInfo.appinfo → FHR data migration: org.mozilla.appInfo
Blocks: 1137160
No longer blocks: 1120356
(Reporter)

Comment 1

3 years ago
All the fields mentioned in the previous comments are already in Telemetry's Environmnent. The newly added "acceptLangIsUserSet" [1] is not, so we should probably port that to Telemetry. This could be easily done by checking whether the user set an intl.accept_languages preference.

[1] - https://ci.mozilla.org/job/mozilla-central-docs/Tree_Documentation/services/healthreport/healthreport/dataformat.html
Summary: FHR data migration: org.mozilla.appInfo → FHR data migration: intl.accept_languages
(In reply to Alessio Placitelli [:Dexter] from comment #1)
> All the fields mentioned in the previous comments are already in Telemetry's
> Environmnent. The newly added "acceptLangIsUserSet" [1] is not, so we should
> probably port that to Telemetry. This could be easily done by checking
> whether the user set an intl.accept_languages preference.
> 
> [1] -
> https://ci.mozilla.org/job/mozilla-central-docs/Tree_Documentation/services/
> healthreport/healthreport/dataformat.html

Benjamin, is that potentially suitable for environment.settings.userPrefs?
Flags: needinfo?(benjamin)

Comment 3

3 years ago
Since acceptlang is fennec-only, I believe there's nothing else that needs to happen here.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(benjamin)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.