1121036 - In Edit Mode, when creating a new group near the bottom of screen, animate expanded group into full view

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[katieC]

In edit mode, when user creates a new group near or close to the bottom of the visible screen area, when new group is created, it grows to the default size of one row and the icon snaps into the first slot. 

The new group snaps up to make sure it’s visible - animate group up into full view for the user.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1121036-focus-new-group > mozilla-b2g:master

Comment 2

[Chris Lord [:cwiiis]]

Added unit test.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8573190 [details] [review]
[gaia] Cwiiis:bug1121036-focus-new-group > mozilla-b2g:master

This is looking pretty good code-wise (there is a jshint issue that you should fix), but I think we need just a little bit more tuning before landing.

The 750ms timeout is quite big, and something I tried cause the page to jump back to where it thinks it should be. Try this - with a bunch of expanded groups, scroll down the page slowly, collapsing groups as you're scrolling. The page will sort of jump to weird areas. I'm wondering if we can clear the timeout on scroll somehow. Maybe either with a scroll handler, or a temporary touchstart handler.

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 8573190 [details] [review]
[gaia] Cwiiis:bug1121036-focus-new-group > mozilla-b2g:master

Re-requesting review, I think this comment must have been for bug 1120884.

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8573190 [details] [review]
[gaia] Cwiiis:bug1121036-focus-new-group > mozilla-b2g:master

Ugh, did I review the wrong bug? *sigh*

This looks good to me though, nice work!

Comment 6

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/379a39ad228cb98d7625438b9ababa8a3fccd171

Comment 7

[Chris Lord [:cwiiis]]

Comment on attachment 8573190 [details] [review]
[gaia] Cwiiis:bug1121036-focus-new-group > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Expanding a group doesn't bring the group into best focus. Small polish issue.
[Testing completed]: Automated and manual testing, and been on master for a while with no reports of bad behaviour.
[Risk to taking this patch] (and alternatives if risky): Low risk, single-line change.
[String changes made]: None.

Comment 8

[bhavana bajaj [:bajaj]]

(In reply to Chris Lord [:cwiiis] from comment #7)
> Comment on attachment 8573190 [details] [review]
> [gaia] Cwiiis:bug1121036-focus-new-group > mozilla-b2g:master
> 
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #):
> [User impact] if declined: Expanding a group doesn't bring the group into
> best focus. Small polish issue.
> [Testing completed]: Automated and manual testing, and been on master for a
> while with no reports of bad behaviour.
> [Risk to taking this patch] (and alternatives if risky): Low risk,
> single-line change.
> [String changes made]: None.

I do want to remind, that we want to avoid the code churn on 2.2 at this time keeping the FC/CC timelines in mind and hence the branch is open for release blockers only at this point. We have been lenient in taking any low risk fixes where worthy(and sometimes that's debatable, hence we stick to blockers only) but these will start getting minused soon, so please don't be disheartened!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/3ea6d7cefb79b7c7eed57debe2d97937b1422198