Closed
Bug 1121037
Opened 9 years ago
Closed 9 years ago
Release mozprofile 0.23
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla38
People
(Reporter: whimboo, Assigned: ujjwal, Mentored)
References
Details
(Whiteboard: [lang=py])
Attachments
(1 file)
951 bytes,
patch
|
whimboo
:
review+
ahal
:
feedback+
|
Details | Diff | Splinter Review |
mozprofile is currently kinda broken in terms for case-sensitive preference names. This problem has been fixed on bug 1100363. So at least for this fix we should get a new release out. I talked to Ujjwal who contributed this fix and he is willed to work on this bug.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8548339 -
Flags: review?(hskupin)
Reporter | ||
Updated•9 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8548339 [details] [diff] [review] bug1121037_release_mozprofile_023.diff Review of attachment 8548339 [details] [diff] [review]: ----------------------------------------------------------------- This looks fine but I wonder if we should also bump the version dependency on mozprofile in mozrunner. Andrew, mind offering your opinion here? I have seen that it is still at >=0.18, and not sure when exactly we bump those dependencies. Is it only for API changes nowadays? I cannot find anything on https://wiki.mozilla.org/Auto-tools/Projects/MozBase.
Attachment #8548339 -
Flags: review?(hskupin)
Attachment #8548339 -
Flags: review+
Attachment #8548339 -
Flags: feedback?(ahalberstadt)
Comment 3•9 years ago
|
||
Comment on attachment 8548339 [details] [diff] [review] bug1121037_release_mozprofile_023.diff Review of attachment 8548339 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, it isn't required unless there's a backwards incompatible API change that also requires an update to mozprofile. In that case whoever made the backwards incompatible API change should have bumped the two at the same time along with their patch, so it should theoretically always be safe to bump one without the other.
Attachment #8548339 -
Flags: feedback?(ahalberstadt) → feedback+
Reporter | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/61cd6ebaaee6
Flags: in-testsuite-
Target Milestone: --- → mozilla38
Reporter | ||
Updated•9 years ago
|
Keywords: leave-open
Reporter | ||
Comment 6•9 years ago
|
||
mozprofile 0.23 has been released to PYPI: Submitting dist/mozprofile-0.23.tar.gz to https://pypi.python.org/pypi Server response (200): OK Thank you Ujjwal for the patch!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•9 years ago
|
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•