Closed
Bug 1121042
Opened 10 years ago
Closed 10 years ago
Remove SourceActor.prototype._getOrCreateBreakpointActor.
Categories
(DevTools :: Debugger, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: ejpbruel, Assigned: ejpbruel)
Details
Attachments
(1 file, 1 obsolete file)
|
2.73 KB,
patch
|
fitzgen
:
review-
|
Details | Diff | Splinter Review |
This method is only called from setBreakpoint, and is sufficiently simple that it doesn't need to be a separate method.
This bug is part of the cleanup of the breakpoint code, and should make it easier to implement breakpoint sliding on original locations later.
Attachment #8548307 -
Flags: review?(nfitzgerald)
|
Assignee | |
Comment 1•10 years ago
|
||
Messed up the patch file. Sorry!
Attachment #8548307 -
Attachment is obsolete: true
Attachment #8548307 -
Flags: review?(nfitzgerald)
Attachment #8548309 -
Flags: review?(nfitzgerald)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8548309 [details] [diff] [review]
patch
Review of attachment 8548309 [details] [diff] [review]:
-----------------------------------------------------------------
Having it contained+abstracted is nice. That method that you inlined it into is already big (and used to be even bigger). What is the point of this change?
Attachment #8548309 -
Flags: review?(nfitzgerald) → review-
|
|
Assignee | |
Comment 3•10 years ago
|
||
I'm going to close this as wontfix because of comment 2.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•