Remove dormant dependent status change from MediaDecoder::SetDormantIfNecessary()

RESOLVED WONTFIX

Status

()

P1
normal
RESOLVED WONTFIX
4 years ago
4 years ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

4 years ago
Since Bug 1108728 fix, dormant specific status was removed from MediaDecoder. But MediaDecoder::SetDormantIfNecessary() is still doing dormant dependent status change to MediaDecoder. It is necessary to be removed from MediaDecoder.
(Assignee)

Updated

4 years ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Updated

4 years ago
Depends on: 1108728
(Assignee)

Updated

4 years ago
Blocks: 1050031
(Assignee)

Updated

4 years ago
Depends on: 1121658
Priority: -- → P1
(Assignee)

Comment 1

4 years ago
(In reply to Sotaro Ikeda [:sotaro] from comment #0)
> Since Bug 1108728 fix, dormant specific status was removed from
> MediaDecoder. But MediaDecoder::SetDormantIfNecessary() is still doing
> dormant dependent status change to MediaDecoder. It is necessary to be
> removed from MediaDecoder.

When the status change is simply removed from MediaDecoder::SetDormantIfNecessary(), the following redundant function calls during resuming from dormant cause incorrect state transition.
- MediaDecoder::FirstFrameLoaded()
- MediaDecoder::SeekingStoppedAtEnd()
- MediaDecoder::SeekingStopped()
(Assignee)

Comment 2

4 years ago
After some investigations, I recognized that MediaDecoder could not be independent from dormant state of MediaDecoderStateMachine. When MediaDecoderStateMachine is in dormant state, MediaDecoder can not change it's state ChangeState(PLAY_STATE_LOADING) realize it. Until file is loaded again, MediaDecoder::mNextState stores status change.
(Assignee)

Comment 3

4 years ago
Set to WONTFIX based on Comment 2.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

4 years ago
No longer depends on: 1121658
(Assignee)

Updated

4 years ago
No longer blocks: 1050031
You need to log in before you can comment on or make changes to this bug.