mfbt/Move.h comments describing perfect forwarding are incorrect

RESOLVED FIXED in mozilla38

Status

()

Core
MFBT
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jimb, Assigned: jimb)

Tracking

unspecified
mozilla38
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The comments in mfbt/Move.h describing perfect forwarding incorrectly state the types to which the template type parameters are resolved.

I think the (soon-to-be) attached patch brings Move.h in line with the description here:

http://thbecker.net/articles/rvalue_references/section_08.html

and the description in the "Nitty Gritty Details" section of this page:

http://isocpp.org/blog/2012/11/universal-references-in-c11-scott-meyers
(Assignee)

Comment 1

3 years ago
Created attachment 8548350 [details] [diff] [review]
Fix comments in Move.h explaining perfect forwarding.
Assignee: nobody → jimb
Status: NEW → ASSIGNED
Attachment #8548350 - Flags: review?(jwalden+bmo)
Comment on attachment 8548350 [details] [diff] [review]
Fix comments in Move.h explaining perfect forwarding.

Review of attachment 8548350 [details] [diff] [review]:
-----------------------------------------------------------------

Glorious.  We probably should introduce "forwarding reference" as a Thing in these docs somewhere:

http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4164.pdf

But one thing at a time, and I am not all that perturbed about the lack at present.
Attachment #8548350 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/74abc1cf0193
Flags: in-testsuite-
Target Milestone: --- → mozilla38
https://hg.mozilla.org/mozilla-central/rev/74abc1cf0193
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.