Closed
Bug 1121080
Opened 9 years ago
Closed 9 years ago
mfbt/Move.h comments describing perfect forwarding are incorrect
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file)
2.30 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
The comments in mfbt/Move.h describing perfect forwarding incorrectly state the types to which the template type parameters are resolved. I think the (soon-to-be) attached patch brings Move.h in line with the description here: http://thbecker.net/articles/rvalue_references/section_08.html and the description in the "Nitty Gritty Details" section of this page: http://isocpp.org/blog/2012/11/universal-references-in-c11-scott-meyers
Assignee | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8548350 [details] [diff] [review] Fix comments in Move.h explaining perfect forwarding. Review of attachment 8548350 [details] [diff] [review]: ----------------------------------------------------------------- Glorious. We probably should introduce "forwarding reference" as a Thing in these docs somewhere: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4164.pdf But one thing at a time, and I am not all that perturbed about the lack at present.
Attachment #8548350 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/74abc1cf0193
Flags: in-testsuite-
Target Milestone: --- → mozilla38
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/74abc1cf0193
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•