Increase number of Gij chunks

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Currently Gij can take 70+ minutes. I think we should cut that in half.
(Assignee)

Comment 1

4 years ago
Created attachment 8548387 [details] [diff] [review]
Patch - Increase number of Gij chunks

Jonathan - would you be the correct reviewer for this?
Attachment #8548387 - Flags: review?(jgriffin)
Comment on attachment 8548387 [details] [diff] [review]
Patch - Increase number of Gij chunks

Review of attachment 8548387 [details] [diff] [review]:
-----------------------------------------------------------------

This change is correct, but won't do anything by itself.  You additionally need to modify the gaia-js-integration-X settings under the particular builds where you want to use more chunks; for b2gdesktop on linux64, that's at http://hg.mozilla.org/build/buildbot-configs/file/6dc553dac3da/mozilla-tests/b2g_config.py#l1212
Attachment #8548387 - Flags: review?(jgriffin) → review-
(Assignee)

Comment 3

4 years ago
Created attachment 8548421 [details] [diff] [review]
Patch - Increase number of Gij chunks

Thanks for the quick response. Does this look better?
Attachment #8548421 - Flags: review?(jgriffin)
(Assignee)

Updated

4 years ago
Attachment #8548387 - Attachment is obsolete: true
Comment on attachment 8548421 [details] [diff] [review]
Patch - Increase number of Gij chunks

Review of attachment 8548421 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, looks good to me.  Note that this will increase the number of chunks on all trees, but I guess that's the desired effect.
Attachment #8548421 - Flags: review?(jgriffin) → review+
(Assignee)

Comment 5

4 years ago
(In reply to Jonathan Griffin (:jgriffin) from comment #4)
> Yep, looks good to me.  Note that this will increase the number of chunks on
> all trees, but I guess that's the desired effect.

Yup. This will be especially useful now as we're working very hard on getting these tests re-enabled. Ten chunks should also be quite scalable into the future as well as we add more tests.
(Assignee)

Comment 6

4 years ago
Can I add checkin-needed to get this landed in the proper build repo?
Keywords: checkin-needed
(In reply to Kevin Grandon :kgrandon [INACTIVE - heads down on Gij Issue] from comment #6)
> Can I add checkin-needed to get this landed in the proper build repo?

Probably not.  I went ahead and landed it for you:

https://hg.mozilla.org/build/buildbot-configs/rev/623b3be90ea4

Note this won't take effect until the next "buildbot reconfig"; you can ask in #releng when that may occur.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.