1121122 - Increase number of Gij chunks

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Kevin Grandon :kgrandon]

Currently Gij can take 70+ minutes. I think we should cut that in half.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Patch - Increase number of Gij chunks

Jonathan - would you be the correct reviewer for this?

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8548387 [details] [diff] [review]
Patch - Increase number of Gij chunks

Review of attachment 8548387 [details] [diff] [review]:
-----------------------------------------------------------------

This change is correct, but won't do anything by itself.  You additionally need to modify the gaia-js-integration-X settings under the particular builds where you want to use more chunks; for b2gdesktop on linux64, that's at http://hg.mozilla.org/build/buildbot-configs/file/6dc553dac3da/mozilla-tests/b2g_config.py#l1212

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Patch - Increase number of Gij chunks

Thanks for the quick response. Does this look better?

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8548421 [details] [diff] [review]
Patch - Increase number of Gij chunks

Review of attachment 8548421 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, looks good to me.  Note that this will increase the number of chunks on all trees, but I guess that's the desired effect.

Comment 5

[Kevin Grandon :kgrandon]

(In reply to Jonathan Griffin (:jgriffin) from comment #4)
> Yep, looks good to me.  Note that this will increase the number of chunks on
> all trees, but I guess that's the desired effect.

Yup. This will be especially useful now as we're working very hard on getting these tests re-enabled. Ten chunks should also be quite scalable into the future as well as we add more tests.

Comment 6

[Kevin Grandon :kgrandon]

Can I add checkin-needed to get this landed in the proper build repo?

Comment 7

[Jonathan Griffin (:jgriffin)]

(In reply to Kevin Grandon :kgrandon [INACTIVE - heads down on Gij Issue] from comment #6)
> Can I add checkin-needed to get this landed in the proper build repo?

Probably not.  I went ahead and landed it for you:

https://hg.mozilla.org/build/buildbot-configs/rev/623b3be90ea4

Note this won't take effect until the next "buildbot reconfig"; you can ask in #releng when that may occur.

Comment 8

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/623b3be90ea4