Closed
Bug 1121185
Opened 9 years ago
Closed 9 years ago
OdinMonkey: relax final-return-statement rules
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: luke, Assigned: luke)
Details
Attachments
(1 file)
|
5.36 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
As discussed in http://discourse.specifiction.org/t/return-type-annotations/731
|
Assignee | |
Comment 1•9 years ago
|
||
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8548470 [details] [diff] [review] relax-ret-type Review of attachment 8548470 [details] [diff] [review]: ----------------------------------------------------------------- Nice, can you add tests in which we *don't* have the final return coercion, please?
Attachment #8548470 -
Flags: review?(benj) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
I can add more, but the two test changes in testControlFlow.js don't have final return coercions.
|
|
||
Comment 4•9 years ago
|
||
Oh right, it wasn't clear to me as they didn't have final return coercions in the first place, but I see operations have been added that change the type of the final returned value. So, good to land.
|
|
Assignee | |
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/38ad6d18d2ce
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/38ad6d18d2ce
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•