[Windows Management] The blue 'active call' notification banner only covers half the screen when in landscape mode.

VERIFIED FIXED in Firefox OS v2.2

Status

Firefox OS
Gaia::System::Window Mgmt
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Joshua Mitchell (Inactive), Assigned: alive)

Tracking

({regression})

unspecified
2.2 S4 (23jan)
ARM
Gonk (Firefox OS)
regression

Firefox Tracking Flags

(b2g-v2.0 unaffected, b2g-v2.1 affected, b2g-v2.2 verified, b2g-master verified)

Details

(Whiteboard: [3.0-Daily-Testing])

Attachments

(4 attachments)

(Reporter)

Description

3 years ago
Created attachment 8548452 [details]
logcat_20150113_1336.txt

Description:
When in an active call and leaving the callscreen (example: hitting the home button) and entering an app in landscape (example: Browser) mode, the banner (which appears every 90 seconds) will only cover 1/2 the screen in landscape apps. This is inconsistent with other notification banners which take up the entire width of the screen.

Repro Steps:
1) Update a Flame to 20150113010202
2) Connect to another phone with an active phone call
3) Exit the callscreen by hitting the home button
4) Enter an app that can be used in landscape and turn device to landscape
5) If the banner has left the screen wait 90 seconds for it to return

Actual:
blue active call banner only takes up half the screen.

Expected:
blue active call banner will take the entire width of the screen to make it consistent with other notification banners.

Environmental Variables:
Device: Flame Master
Build ID: 20150113010202
Gaia: 9946a490a9264b42e65385d703b28fa055ab2d42
Gecko: 3d846527576f
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 38.0a1 (Master)
Firmware Version: V18d-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 9/9
See attached: screenshot, logcat

---------------------------------------------------------------------------------------

This issue also repros on Flame 2.2 (V18d), 2.2 (v18d-1), and 2.1 (v18d-1)

Device: Flame 2.2 (KK - Nightly - Full-Flashed)
Build ID: 20150112010228
Gaia: f5e481d4caf9ffa561720a6fc9cf521a28bd8439
Gecko: bb8d6034f5f2
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 
Firmware Version: V18d-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.2 (KK - Nightly - Full-Flashed)
Build ID: 20150112010228
Gaia: f5e481d4caf9ffa561720a6fc9cf521a28bd8439
Gecko: bb8d6034f5f2
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 
Firmware Version: V18d
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.1 (KK - Nightly - Full-Flashed)
Build ID: 20150113001255
Gaia: 836e6d74cb8b7016df555f85445893b3ff9aac12
Gecko: 074f79a929d2
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 34.0 (2.1)
Firmware Version: V18d-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

----------------------------------------------------------------------------------------------

This issue does NOT reproduce in 2.0 (v18d-1)

Actual Results: The banner takes the entire width of the screen (The banner also does not time out and disappear / reappear so this MIGHT be considered different functionality and not a true regression - or this might simply be the introduced behavior (time-out function) that broke the width in conjunction with its implementation. 

Device: Flame 2.0 (KK - Nightly - Full-Flashed)
Build ID: 20150113000203
Gaia: 31d6c9422cd0a8213df9f96019c9ab7168ec3ab3
Gecko: c6fd5db59e0e
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 32.0 (2.0)
Firmware Version: V18d-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
(Reporter)

Comment 1

3 years ago
Created attachment 8548453 [details]
2015-01-13-11-48-14.png
(Reporter)

Updated

3 years ago
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
NI on Component owner for nomination decision and assignment.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga) → needinfo?(pmathur)
:alive, could you please comment?
Flags: needinfo?(pmathur) → needinfo?(alive)
Good catch! Taken
Assignee: nobody → alive
Flags: needinfo?(alive)
Created attachment 8548598 [details] [review]
[PullReq] alivedise:bugzilla/1121189/attention-window-on-landscape to mozilla-b2g:master
Comment on attachment 8548598 [details] [review]
[PullReq] alivedise:bugzilla/1121189/attention-window-on-landscape to mozilla-b2g:master

Root cause is we are resizing on showing. Learned from you that we could unset the width to avoid hardcode width affect the landscape mode.
Attachment #8548598 - Flags: review?(etienne)
Attachment #8548598 - Flags: review?(etienne) → review+
https://github.com/mozilla-b2g/gaia/commit/90e1a2525d3cded5945cfaee277ac8d6075beb8c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-b2g-master: affected → fixed
Resolution: --- → FIXED
Nominate blocking - regression
blocking-b2g: --- → 2.2?
Comment on attachment 8548598 [details] [review]
[PullReq] alivedise:bugzilla/1121189/attention-window-on-landscape to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Regression from bug 1068470
[User impact] if declined: User will see attention toaster to be cut when in landscape mode
[Testing completed]: Try green
[Risk to taking this patch] (and alternatives if risky): Riskless - one line fix (removing css width on resize)
[String changes made]: NaN
Attachment #8548598 - Flags: approval-gaia-v2.2?
QA Contact: ktucker
This issue has been verified as fixed on Flame 3.0

The call banner goes from end to end at the top of the screen while in landscape mode. 

Environmental Variables:
Device: Flame 3.0(Full Flash)(KK)319mb)
BuildID: 20150121010204
Gaia: 5e98dc164b17fd6decb48a9eaddef0e55b82e249
Gecko: 540077a30866
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
Status: RESOLVED → VERIFIED
status-b2g-master: fixed → verified

Updated

3 years ago
Attachment #8548598 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
v2.2: https://github.com/mozilla-b2g/gaia/commit/34e2f727e45f3476f05d23056526228727892d43
status-b2g-v2.2: affected → fixed
Target Milestone: --- → 2.2 S4 (23jan)
Clearing the blocking nom for 2.2? as this is already fixed/verified on that branch per the status flag
blocking-b2g: 2.2? → ---

Comment 13

3 years ago
Created attachment 8629824 [details]
verified_v2.2.3gp

According to the STR of Comment 0, this bug has been verified as pass on latest Nightly Flame v2.2.

Actual results: 
Blue active call banner will occupy the entire width of the screen.
See attachment: verified_v2.2.3gp
Reproduce rate: 0/6


Device: Flame 2.2 build(Pass)
Build ID               20150705002505
Gaia Revision          ea11f422b687a982f0a961c9aea7858066561707
Gaia Date              2015-07-02 23:37:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c0214b4c1ea0
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150705.040440
Firmware Date          Sun Jul  5 04:04:51 EDT 2015
Bootloader             L1TC000118D0

Updated

3 years ago
QA Whiteboard: [MGSEI-Triage+]
status-b2g-v2.2: fixed → verified
You need to log in before you can comment on or make changes to this bug.