We should use sockit-to-me's built in socket poll timeout during waitForSocket.
Created attachment 8548501 [details] [review] Pull Request - Use sockit-to-me built in socket timeout to avoid socket misuse. Need to wait for sockit-to-me update before landing this.
Comment on attachment 8548501 [details] [review] Pull Request - Use sockit-to-me built in socket timeout to avoid socket misuse. lgtm
Commit (master): https://github.com/mozilla-b2g/marionette-js-client/commit/ed62fd839067e3f6d6aef4f3996e953f0a54306a Fixed.
There are issues with this change. I have a new Pull Request with more a more appropriate change -- https://github.com/mozilla-b2g/marionette-js-client/pull/127.
Created attachment 8549268 [details] Pull Request - Better interval, timeout and socket timeout.
Comment on attachment 8549268 [details] Pull Request - Better interval, timeout and socket timeout. Ok, let's try this dance again. In master: https://github.com/mozilla-b2g/marionette-js-client/commit/b56005095764d8b6ad2858e429fafd10ee89fec9 Version bumped to 1.5.4: https://github.com/mozilla-b2g/marionette-js-client/commit/095617c4afb50fb28d4aad3d9ca81537e06a62a5
Nope, this is still failing in gaia-try: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=6c0adedd635f Going to backout the packages, and recommend we test on gaia-try before doing the module dance again.
Here's the latest test run that's going: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=df238f6c73c5 I think my changes to the Makefile weren't complete enough for other test runs and it would still try and pull the wrong versions from mozilla-b2g instead of my own repository for gaia-node-modules. Otherwise, I'm not seeing any failures that are new. Only existing intermittents. Said intermittents are *not* failing because of lack of connecting or timeouts. That's promising.
Created attachment 8550415 [details] [review] Pull Request - As tested on gaia-try. I'll set the review flag on this as soon as the gaia-try runs look good.
We're going to land this as part of bug 1104285.