Closed Bug 1121234 Opened 9 years ago Closed 9 years ago

[sockit-to-me] Enable setPollTimeout to influence 'connect' timeout

Categories

(Testing Graveyard :: JSMarionette, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
B2G C4 (2jan on)

People

(Reporter: aus, Assigned: aus)

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

Currently calling setPollTimeout has no affect on timeouts for calls during connect. We should also prevent connect from being called twice without close being called.
Pull request coming soon.
Status: NEW → ASSIGNED
Also removes support for node 0.8.x.
Whiteboard: [systemsfe]
Comment on attachment 8548570 [details] [review]
Pull Request - Enable setPollTimeout to influence connect timeout. Do not allow connect to be called while already connecting.

I took a look through the code. I'm not super familiar with this project, or sockets, so I probably couldn't give you the best review. You may want to consider flagging someone else if you would like a better design review. For now I think I'm fine R+ stamping this due to the desire to get the issue fixed.

Please land this and bump the version in npm. Thanks!
Attachment #8548570 - Flags: review?(kgrandon) → review+
This looks good to me should help narrow down any cases that have these issues...
Hey - can one of you guys get this landed/do the janky linux build/published to npm? Thanks!
Flags: needinfo?(gaye)
Flags: needinfo?(aus)
If gaye isn't set-up to build this thing anymore I can set-up a VM with the correct Ubuntu version to build this today.
Flags: needinfo?(aus)
Ok, I think :gaye volunteered when I chatted with him earlier - just didn't want you guys to duplicate efforts. As long as you guys are talking things should be fine :)
Commit (master): https://github.com/mozilla-b2g/sockit-to-me/commit/ea23d94cc72d7232bf65aa94874da5bb9901c991

Version bumped to v0.2.4. Still need to build on Ubuntu 13.04 prior to releasing via NPM.

Will keep this open until we push to NPM.
Actually, it's on Ubuntu Precise 12.04 (i386 and amd64). Ouch. Luckily Amazon AWS still has those. Binaries are building now.
Flags: needinfo?(gaye)
Comment on attachment 8549128 [details] [review]
Pull Request - New binaries for Ubuntu 12.04 i386 and amd64

r=me, just need to keep this moving as fast as possible.
Attachment #8549128 - Flags: review?(gaye) → review+
Commit (master): https://github.com/mozilla-b2g/sockit-to-me/commit/bd2b8c17dba90db325f87f9d6bbe958668ec8912

New binaries landed. New node module published to NPM. Fixed.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: